Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios

From	Vivek Gautam <vivek.gautam@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios
Date	2017-07-28 08:10 +0200
Message-ID	<u86Df-8nH-11@gated-at.bofh.it> (permalink)
References	<u7KCJ-2Dt-13@gated-at.bofh.it> <u7KCJ-2Dt-11@gated-at.bofh.it> <u7YcG-2T1-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 28, 2017 at 2:30 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 07/26/2017 11:30 PM, Vivek Gautam wrote:
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
>> index d3879a4e8076..3b04ca63c31e 100644
>> --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
>> @@ -8,6 +8,23 @@
>>               reg = <0x2 SPMI_USID>;
>>               #address-cells = <1>;
>>               #size-cells = <0>;
>> +
>> +             pmi8994_gpios: gpios@c000 {
>> +                     compatible = "qcom,pmi8994-gpio";
>
>
> Please also include the generic "qcom,spmi-gpio" compatible. We really
> don't need to add the "qcom,pmi8994-gpio" one to the driver right now so
> I would leave that out of the driver but leave it here in the dtsi file
> of course.

Sure, will add the "qcom,spmi-gpio" compatible as well, and will drop the
"qcom,pmi8994-gpio" from the driver.
Thanks.

regards
Vivek

>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-07-27 08:40 +0200
  Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios Stephen Boyd <sboyd@codeaurora.org> - 2017-07-27 23:10 +0200
    Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-07-28 08:10 +0200

csiph-web