Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698458

Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks

Show all headers | View raw

On Thu, Jul 27, 2017 at 12:55 PM, Saravana Kannan
<skannan@codeaurora.org> wrote:
> On 07/26/2017 08:30 PM, Viresh Kumar wrote:
>>
>> On 26-07-17, 14:00, Saravana Kannan wrote:
>>>
>>> No, the alternative is to pass it on to the CPU freq driver and let it
>>> decide what it wants to do. That's the whole point if having a CPU freq
>>> driver -- so that the generic code doesn't need to care about HW specific
>>> details. Which is the point I was making in an earlier email to Viresh's
>>> patch -- we shouldn't be doing any CPU check for the call backs at the
>>> scheduler or ever governor level.
>>>
>>> That would simplify this whole thing by deleting a bunch of code. And
>>> having
>>> much simpler checks in those drivers that actually have to deal with
>>> their
>>> HW specific details.
>>
>>
>> So what you are saying is that we go and update (almost) every cpufreq
>> driver we have today and make their ->target() callbacks return early
>> if they don't support switching frequency remotely ? Is that really
>> simplifying anything?
>
>
> Yes. Simplifying isn't always about number of lines of code. It's also about
> abstraction. Having generic scheduler code care about HW details doesn't
> seem nice.
>
> It'll literally one simple check (cpu == smp_processor_id()) or (cpu "in"
> policy->cpus).
>

I think we can have both approaches? So we query the driver some time
around sugov_should_update_freq (with a new driver callback?) and ask
it if it has any say over the default behavior of "can't update remote
CPU if I'm not a part of its policy" and use that over the default if
it hasn't defined it in their struct cpufreq_driver.

I think this will also not have the concern of "updating every
driver", then we can just stick to the sane default of "no" for
drivers that haven't defined it. Probably Viresh has already thought
about this, but I just thought of bringing it up anyway. I also think
its fine to handle this case after this series gets in, but that's
just my opinion.

thanks!

-Joel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks Peter Zijlstra <peterz@infradead.org> - 2017-07-21 15:10 +0200
  Re: [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-24 13:10 +0200
    Re: [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks Peter Zijlstra <peterz@infradead.org> - 2017-07-24 15:50 +0200
      Re: [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-26 08:30 +0200
        Re: [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks Peter Zijlstra <peterz@infradead.org> - 2017-07-26 10:20 +0200
        Re: [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 19:40 +0200
  Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq  callbacks Saravana Kannan <skannan@codeaurora.org> - 2017-07-26 23:10 +0200
    Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq  callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-27 05:40 +0200
      Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq  callbacks Saravana Kannan <skannan@codeaurora.org> - 2017-07-27 22:00 +0200
        Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks "Joel Fernandes (Google)" <joel.opensrc@gmail.com> - 2017-07-28 06:40 +0200
        Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq  callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-28 08:10 +0200
          Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq  callbacks Saravana Kannan <skannan@codeaurora.org> - 2017-07-28 23:10 +0200
            Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq  callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-31 06:00 +0200

csiph-web