Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1698436
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver |
| Date | 2017-07-28 05:20 +0200 |
| Message-ID | <u83YJ-6Cu-3@gated-at.bofh.it> (permalink) |
| References | <u7nd7-4CC-5@gated-at.bofh.it> <u7nd8-4CC-13@gated-at.bofh.it> <u7xYT-37A-35@gated-at.bofh.it> <u7Irf-1iX-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote:
> On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote:
> >> drivers/dma/bcm-sba-raid.c | 439 +++++++++++++++++++++++----------------------
> >> 1 file changed, 226 insertions(+), 213 deletions(-)
> >>
> >> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> >> index e41bbc7..6d15fed 100644
> >> --- a/drivers/dma/bcm-sba-raid.c
> >> +++ b/drivers/dma/bcm-sba-raid.c
> >> @@ -48,7 +48,8 @@
> >>
> >> #include "dmaengine.h"
> >>
> >> -/* SBA command related defines */
> >> +/* ====== Driver macros and defines ===== */
> >
> > why this noise, seems unrelated to the change!
>
> This is just minor beautification. Again, I will put this
> in separate patch.
Well you can't shove garlands under an unrelated change. By all means throw
the whole garden out there, but please as a separate patch
>
> >
> >> +
> >> #define SBA_TYPE_SHIFT 48
> >> #define SBA_TYPE_MASK GENMASK(1, 0)
> >> #define SBA_TYPE_A 0x0
> >> @@ -82,39 +83,41 @@
> >> #define SBA_CMD_WRITE_BUFFER 0xc
> >> #define SBA_CMD_GALOIS 0xe
> >>
> >> -/* Driver helper macros */
> >> +#define SBA_MAX_REQ_PER_MBOX_CHANNEL 8192
> >> +
> >> #define to_sba_request(tx) \
> >> container_of(tx, struct sba_request, tx)
> >> #define to_sba_device(dchan) \
> >> container_of(dchan, struct sba_device, dma_chan)
> >>
> >> -enum sba_request_state {
> >> - SBA_REQUEST_STATE_FREE = 1,
> >> - SBA_REQUEST_STATE_ALLOCED = 2,
> >> - SBA_REQUEST_STATE_PENDING = 3,
> >> - SBA_REQUEST_STATE_ACTIVE = 4,
> >> - SBA_REQUEST_STATE_RECEIVED = 5,
> >> - SBA_REQUEST_STATE_COMPLETED = 6,
> >> - SBA_REQUEST_STATE_ABORTED = 7,
> >> +/* ===== Driver data structures ===== */
> >> +
> >> +enum sba_request_flags {
> >> + SBA_REQUEST_STATE_FREE = 0x001,
> >> + SBA_REQUEST_STATE_ALLOCED = 0x002,
> >> + SBA_REQUEST_STATE_PENDING = 0x004,
> >> + SBA_REQUEST_STATE_ACTIVE = 0x008,
> >> + SBA_REQUEST_STATE_RECEIVED = 0x010,
> >> + SBA_REQUEST_STATE_COMPLETED = 0x020,
> >> + SBA_REQUEST_STATE_ABORTED = 0x040,
> >> + SBA_REQUEST_STATE_MASK = 0x0ff,
> >> + SBA_REQUEST_FENCE = 0x100,
> >
> > how does this help in mem alloctn?
??
--
~Vinod
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] Broadcom SBA-RAID driver improvements Anup Patel <anup.patel@broadcom.com> - 2017-07-26 07:40 +0200
[PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver Anup Patel <anup.patel@broadcom.com> - 2017-07-26 07:40 +0200
Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver Vinod Koul <vinod.koul@intel.com> - 2017-07-26 19:10 +0200
Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver Anup Patel <anup.patel@broadcom.com> - 2017-07-27 06:20 +0200
Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver Vinod Koul <vinod.koul@intel.com> - 2017-07-28 05:20 +0200
Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver Anup Patel <anup.patel@broadcom.com> - 2017-07-28 05:50 +0200
[PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests Anup Patel <anup.patel@broadcom.com> - 2017-07-26 07:40 +0200
Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests Vinod Koul <vinod.koul@intel.com> - 2017-07-26 19:10 +0200
Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests Anup Patel <anup.patel@broadcom.com> - 2017-07-27 07:00 +0200
Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests Vinod Koul <vinod.koul@intel.com> - 2017-07-28 05:20 +0200
Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests Anup Patel <anup.patel@broadcom.com> - 2017-07-28 05:40 +0200
[PATCH 6/6] arm64: dts: Add SBA-RAID DT nodes for Stingray SoC Anup Patel <anup.patel@broadcom.com> - 2017-07-26 07:40 +0200
Re: [PATCH 0/6] Broadcom SBA-RAID driver improvements Vinod Koul <vinod.koul@intel.com> - 2017-07-26 19:10 +0200
Re: [PATCH 0/6] Broadcom SBA-RAID driver improvements Anup Patel <anup.patel@broadcom.com> - 2017-07-27 06:10 +0200
csiph-web