Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698383

Re: [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 26 Jul 2017 17:14:00 +0200

> The driver attempts to 'select MDIO_DEVICE', but the code
> is actually a loadable module when PHYLIB=m:
> 
> drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write':
> phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write'
> drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit':
> phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister'
> drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init':
> phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register'
> phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister'
> 
> Using 'depends on MDIO_BUS' instead will avoid the link error.
> 
> Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS Arnd Bergmann <arnd@arndb.de> - 2017-07-26 17:20 +0200
  [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-26 17:20 +0200
    Re: [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency David Miller <davem@davemloft.net> - 2017-07-28 02:30 +0200
  Re: [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS David Miller <davem@davemloft.net> - 2017-07-28 02:30 +0200

csiph-web