Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697426

[tip:perf/core] perf annotate: Do not overwrite sample->period

From tip-bot for Taeung Song <tipbot@zytor.com>
Newsgroups linux.kernel
Subject [tip:perf/core] perf annotate: Do not overwrite sample->period
Date 2017-07-26 19:30 +0200
Message-ID <u7yig-3eE-49@gated-at.bofh.it> (permalink)
References <u54Rl-5Zi-47@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Commit-ID:  ecd5f9959d2c9540482977ff1208ea67fbfb8cc9
Gitweb:     http://git.kernel.org/tip/ecd5f9959d2c9540482977ff1208ea67fbfb8cc9
Author:     Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Fri, 21 Jul 2017 11:38:48 -0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 21 Jul 2017 12:02:52 -0300

perf annotate: Do not overwrite sample->period

In fixing the --show-total-period option it was noticed that the value
of sample->period was being overwritten, fix it.

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Fixes: fd36f3dd7933 ("perf hist: Pass struct sample to __hists__add_entry()")
Link: http://lkml.kernel.org/r/1500500215-16646-1-git-send-email-treeze.taeung@gmail.com
[ split from a larger patch, added the Fixes tag ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-annotate.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 96fe1a8..7e33278 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -177,7 +177,6 @@ static int perf_evsel__add_sample(struct perf_evsel *evsel,
 	 */
 	process_branch_stack(sample->branch_stack, al, sample);
 
-	sample->period = 1;
 	sample->weight = 1;
 
 	he = hists__add_entry(hists, al, NULL, NULL, NULL, sample, true);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples Taeung Song <treeze.taeung@gmail.com> - 2017-07-19 23:40 +0200
  Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-20 21:20 +0200
    Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Taeung Song <treeze.taeung@gmail.com> - 2017-07-21 11:50 +0200
      Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-21 13:30 +0200
        Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Taeung Song <treeze.taeung@gmail.com> - 2017-07-24 04:00 +0200
          Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-24 19:40 +0200
            Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Taeung Song <treeze.taeung@gmail.com> - 2017-07-24 23:30 +0200
              Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-25 16:50 +0200
                Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Taeung Song <treeze.taeung@gmail.com> - 2017-07-25 18:00 +0200
                Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-25 18:20 +0200
                Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Taeung Song <treeze.taeung@gmail.com> - 2017-07-26 14:00 +0200
                Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-26 22:20 +0200
                Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Taeung Song <treeze.taeung@gmail.com> - 2017-07-27 17:20 +0200
              [tip:perf/core] perf annotate stdio: Fix column header when using  --show-total-period tip-bot for Taeung Song <tipbot@zytor.com> - 2017-07-26 19:30 +0200
  Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-21 17:00 +0200
    Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Namhyung Kim <namhyung@kernel.org> - 2017-07-23 00:50 +0200
      Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Andi Kleen <andi@firstfloor.org> - 2017-07-23 17:50 +0200
        Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-24 19:40 +0200
          Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Andi Kleen <andi@firstfloor.org> - 2017-07-24 19:50 +0200
            Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period  option showing number of samples Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-24 20:10 +0200
  [tip:perf/core] perf annotate: Store the sample period in each  histogram bucket tip-bot for Taeung Song <tipbot@zytor.com> - 2017-07-26 19:30 +0200
  [tip:perf/core] perf annotate: Do not overwrite sample->period tip-bot for Taeung Song <tipbot@zytor.com> - 2017-07-26 19:30 +0200
  [tip:perf/core] perf hists: Pass perf_sample to  __symbol__inc_addr_samples() tip-bot for Taeung Song <tipbot@zytor.com> - 2017-07-26 19:30 +0200

csiph-web