Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697206

Re: [PATCH RESEND] fbdev: omapfb: remove unused variable

Show all headers | View raw

Hi,

On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote:
> Removing the default display name left a harmless warning:
> 
> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
> 
> This removes the now-unused variable as well.
> 
> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Originally submitted on June 9, no reply other than the Reviewed-by tag.
> The patch is still needed

It is not lost and will be queued for 4.13 fbdev fixes pull request.

[ The guilty commit went through DRM tree and pulling it into fbdev
  tree just to fix the warning was not feasible.. ]

> ---
>  drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c
> index eecf695c16f4..09e5bb013d28 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
> @@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {
>  
>  static int __init omap_dss_probe(struct platform_device *pdev)
>  {
> -	struct omap_dss_board_info *pdata = pdev->dev.platform_data;
>  	int r;
>  
>  	core.pdev = pdev;

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] fbdev: omapfb: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-07-26 16:00 +0200
  Re: [PATCH RESEND] fbdev: omapfb: remove unused variable Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-07-26 16:30 +0200
    Re: [PATCH RESEND] fbdev: omapfb: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-07-26 16:40 +0200
      Re: [PATCH RESEND] fbdev: omapfb: remove unused variable Daniel Vetter <daniel@ffwll.ch> - 2017-07-26 17:00 +0200

csiph-web