Re: [PATCH] media: v4l: use WARN_ON(1) instead of __WARN()

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] media: v4l: use WARN_ON(1) instead of __WARN()
Date	2017-07-26 13:30 +0200
Message-ID	<u7sFP-86J-3@gated-at.bofh.it> (permalink)
References	<u7afU-4DI-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue 2017-07-25 17:39:14, Arnd Bergmann wrote:
> __WARN() cannot be used in portable code, since it is only
> available on some architectures and configurations:
> 
> drivers/media/platform/pxa_camera.c: In function 'pxa_mbus_config_compatible':
> drivers/media/platform/pxa_camera.c:642:3: error: implicit declaration of function '__WARN'; did you mean '__WALL'? [-Werror=implicit-function-declaration]
> 
> The common way to express an unconditional warning is WARN_ON(1),
> so let's use that here.
> 
> Fixes: 97bbdf02d905 ("media: v4l: Add support for CSI-1 and CCP2 busses")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] media: v4l: use WARN_ON(1) instead of __WARN() Arnd Bergmann <arnd@arndb.de> - 2017-07-25 17:50 +0200
  Re: [PATCH] media: v4l: use WARN_ON(1) instead of __WARN() Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-26 01:00 +0200
  Re: [PATCH] media: v4l: use WARN_ON(1) instead of __WARN() Pavel Machek <pavel@ucw.cz> - 2017-07-26 13:30 +0200

csiph-web