Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1696973

Re: [PATCHv1 02/14] drm/omap: drop incorrect comment

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon 2017-07-24 19:32:59, Sebastian Reichel wrote:
> The wrappers have been removed in commit 5a35876e2830
> (drm: omapdrm: Remove manual update display support)
> and will not be reintroduced, since the normal sys
> functions properly call the dirty callback.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

Acked-by: Pavel Machek <pavel@ucw.cz>

> ---
>  drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> index daf81a0a2899..929a3ef0fba0 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -84,9 +84,6 @@ static struct fb_ops omap_fb_ops = {
>  	.owner = THIS_MODULE,
>  	DRM_FB_HELPER_DEFAULT_OPS,
>  
> -	/* Note: to properly handle manual update displays, we wrap the
> -	 * basic fbdev ops which write to the framebuffer
> -	 */
>  	.fb_read = drm_fb_helper_sys_read,
>  	.fb_write = drm_fb_helper_sys_write,
>  	.fb_fillrect = drm_fb_helper_sys_fillrect,

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv1 00/14] omapdrm: DSI command mode panel support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
  [PATCHv1 12/14] drm/omap: panel-dsi-cm: switch to gpiod Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
  [PATCHv1 01/14] drm/omap: remove unused function defines Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
    Re: [PATCHv1 01/14] drm/omap: remove unused function defines Pavel Machek <pavel@ucw.cz> - 2017-07-26 12:50 +0200
  [PATCHv1 04/14] drm/omap: add framedone interrupt support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
  [PATCHv1 05/14] drm/omap: add manual update detection helper Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
  [PATCHv1 06/14] drm/omap: add support for manually updated displays Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
  [PATCHv1 02/14] drm/omap: drop incorrect comment Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
    Re: [PATCHv1 02/14] drm/omap: drop incorrect comment Pavel Machek <pavel@ucw.cz> - 2017-07-26 12:50 +0200
  [PATCHv1 07/14] drm/omap: add support for physical size hints from display drivers Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
    Re: [PATCHv1 07/14] drm/omap: add support for physical size hints  from display drivers Pavel Machek <pavel@ucw.cz> - 2017-07-26 12:50 +0200
  [PATCHv1 03/14] drm/omap: plane: update fifo size on ovl setup Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
  [PATCHv1 14/14] ARM: dts: n950: add display support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
    Re: [PATCHv1 14/14] ARM: dts: n950: add display support Pavel Machek <pavel@ucw.cz> - 2017-07-26 12:50 +0200
  [PATCHv1 13/14] ARM: dts: omap4-droid4: improve LCD description Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-24 19:40 +0200
  Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support Tony Lindgren <tony@atomide.com> - 2017-07-27 14:10 +0200

csiph-web