Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1696762
| From | Jason Wang <jasowang@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] virtio-net: fix module unloading |
| Date | 2017-07-26 06:00 +0200 |
| Message-ID | <u7lEm-3wP-9@gated-at.bofh.it> (permalink) |
| References | <u6LKz-5uV-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2017年07月24日 21:38, Andrew Jones wrote:
> Unregister the driver before removing multi-instance hotplug
> callbacks. This order avoids the warning issued from
> __cpuhp_remove_state_cpuslocked when the number of remaining
> instances isn't yet zero.
>
> Fixes: 8017c279196a ("net/virtio-net: Convert to hotplug state machine")
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> drivers/net/virtio_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 99a26a9efec1..f41ab0ea942a 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2743,9 +2743,9 @@ module_init(virtio_net_driver_init);
>
> static __exit void virtio_net_driver_exit(void)
> {
> + unregister_virtio_driver(&virtio_net_driver);
> cpuhp_remove_multi_state(CPUHP_VIRT_NET_DEAD);
> cpuhp_remove_multi_state(virtionet_online);
> - unregister_virtio_driver(&virtio_net_driver);
> }
> module_exit(virtio_net_driver_exit);
>
Acked-by: Jason Wang <jasowang@redhat.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] virtio-net: fix module unloading Andrew Jones <drjones@redhat.com> - 2017-07-24 15:40 +0200
Re: [PATCH] virtio-net: fix module unloading Jason Wang <jasowang@redhat.com> - 2017-07-26 06:00 +0200
Re: [PATCH] virtio-net: fix module unloading "Michael S. Tsirkin" <mst@redhat.com> - 2017-07-26 15:00 +0200
csiph-web