Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1696700

Re: [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c

Show all headers | View raw

On Tue, Jul 25, 2017 at 5:11 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Tue, Jul 25, 2017 at 4:35 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>> In this case, there isn't a sensible way to continue.
>
> Kees, stop this idiocy already.
>
> These have been FALSE POSITIVES. They haven't actually been bugs in
> the code, they have been bugs in the *checking* code.
>
> In two years, when this code is actually trusted, that would be one thing.

Okay, fair enough. As long as there is a time horizon where this can
operate as an actual runtime protection, I can accept that.

> But right now, it's a f*cking disgrace that you are in denial about
> the fact that it's the *checking* that is broken, not the code, and
> are making excuses for shit.

I'm not in denial about that -- I think we just have very different
perspectives on this. I sent a bunch of patches to fix all the places
where there were false positives being found before this landed; I'm
not making excuses and I'm obviously interested in fixing it.

> So get rid of the BUG(), and get rid of the excuses.

I'll get it fixed up.

> We *know* this code is likely to find these kinds of "not really a
> bug, but the checker code does something we didn't used to do"
> situations.

Yup, agreed. We've already fixed a bunch of these, and while this
checking would catch some actual security vulnerabilities from the
past, I can see your point about its "newness" being too great a risk.

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-20 06:10 +0200
  Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Daniel Micay <danielmicay@gmail.com> - 2017-07-20 06:50 +0200
  Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-20 15:50 +0200
  Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-20 18:00 +0200
    Re: [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-20 20:50 +0200
      Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-21 00:30 +0200
      Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-21 05:40 +0200
  Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Ye Xiaolong <xiaolong.ye@intel.com> - 2017-07-21 04:10 +0200
    Re: [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c Kees Cook <keescook@chromium.org> - 2017-07-21 07:50 +0200
    Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-21 11:20 +0200
      Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Petr Mladek <pmladek@suse.com> - 2017-07-21 12:10 +0200
  Re: [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c Kees Cook <keescook@chromium.org> - 2017-07-26 01:40 +0200
    Re: [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-26 02:20 +0200
      Re: [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c Kees Cook <keescook@chromium.org> - 2017-07-26 02:40 +0200
        Re: [lkp-robot] [include/linux/string.h] 6974f0c455:  kernel_BUG_at_lib/string.c Daniel Micay <danielmicay@gmail.com> - 2017-07-26 04:40 +0200

csiph-web