Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1696698
| From | srinivas.kandagatla@linaro.org |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v1 1/6] ASoC: jack: fix snd_soc_codec_set_jack return error |
| Date | 2017-07-26 02:40 +0200 |
| Message-ID | <u7iwO-1zY-39@gated-at.bofh.it> (permalink) |
| References | <u7iwN-1zY-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> This patch changes the error code returned by snd_soc_codec_set_jack() from -EINVAL to -ENOTSUPP. The reason to do this is to make the caller aware that the underlying codec does not support this callback. This can make the caller write the code to handle this case properly. Other reason is that -EINVAL is not the correct error to return in this case anyway. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- sound/soc/soc-jack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index 7daf21f..42ca9f1 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -36,7 +36,7 @@ int snd_soc_codec_set_jack(struct snd_soc_codec *codec, if (codec->driver->set_jack) return codec->driver->set_jack(codec, jack, data); else - return -EINVAL; + return -ENOTSUPP; } EXPORT_SYMBOL_GPL(snd_soc_codec_set_jack); -- 2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v1 0/6] ASoC: codecs: msm8916-wcd-analog: Add support to MBHC srinivas.kandagatla@linaro.org - 2017-07-26 02:40 +0200
[PATCH v1 2/6] ASoC: codecs: msm8916-analog: fix DIG_CLK_CTL_RXD3_CLK_EN define srinivas.kandagatla@linaro.org - 2017-07-26 02:40 +0200
Re: [PATCH v1 2/6] ASoC: codecs: msm8916-analog: fix DIG_CLK_CTL_RXD3_CLK_EN define Mark Brown <broonie@kernel.org> - 2017-07-28 15:40 +0200
[PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 srinivas.kandagatla@linaro.org - 2017-07-26 02:40 +0200
Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 Mark Brown <broonie@kernel.org> - 2017-07-28 15:50 +0200
Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-07-28 16:00 +0200
Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 Mark Brown <broonie@kernel.org> - 2017-07-28 16:10 +0200
Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-07-28 16:50 +0200
Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 Mark Brown <broonie@kernel.org> - 2017-07-31 12:10 +0200
Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-07-31 12:30 +0200
[PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog: add MBHC support srinivas.kandagatla@linaro.org - 2017-07-26 02:40 +0200
Re: [PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog: add MBHC support Mark Brown <broonie@kernel.org> - 2017-07-28 16:00 +0200
Re: [PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog: add MBHC support Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-07-28 16:20 +0200
[PATCH v1 1/6] ASoC: jack: fix snd_soc_codec_set_jack return error srinivas.kandagatla@linaro.org - 2017-07-26 02:40 +0200
csiph-web