Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1696246

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

Show all headers | View raw

On Tue, Jul 25, 2017 at 3:38 AM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
> On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez wrote:
>> On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote:
>> > On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier <thgarnie@google.com
>> > > wrote:
>> > >
>> > > The work pending loop can call set_fs after addr_limit_user_check
>> > > removed the _TIF_FSCHECK flag. To prevent the infinite loop, move
>> > > the addr_limit_user_check call at the beginning of the loop.
>> > >
>> > > Fixes: 73ac5d6a2b6a ("arm/syscalls: Check address limit on user-
>> > > mode return")
>> > > Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
>> > > Signed-off-by: Thomas Garnier <thgarnie@google.com>
>>
>> > Any comments on this patch set?
>>
>> Tested-by: Leonard Crestez <leonard.crestez@nxp.com>
>>
>> This appears to fix the original issue of failing to boot from NFS when
>> there are lots of alignment faults. But this is a very basic test
>> relative to the reach of this change.
>>
>> However the original patch has been in linux-next for a while and
>> apparently nobody else noticed system calls randomly hanging on arm.
>>
>> I assume maintainers need to give their opinion.
>
> I've already stated my opinion, which is different from what Linus has
> requested of Thomas.  IMHO, the current approach is going to keep on
> causing problems along the lines that I've already pointed out.

I understand. Do you think this problem apply to arm64 as well?

>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.



-- 
Thomas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] arm/syscalls: Move address limit check in loop Thomas Garnier <thgarnie@google.com> - 2017-07-19 20:00 +0200
  [PATCH 2/3] arm/syscalls: Optimize work flags assembly check Thomas Garnier <thgarnie@google.com> - 2017-07-19 20:00 +0200
  Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop Thomas Garnier <thgarnie@google.com> - 2017-07-24 19:10 +0200
    Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-07-25 12:40 +0200
      Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop Thomas Garnier <thgarnie@google.com> - 2017-07-25 22:10 +0200
        Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop Will Deacon <will.deacon@arm.com> - 2017-07-26 14:10 +0200
          Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop Thomas Garnier <thgarnie@google.com> - 2017-07-26 16:30 +0200
            Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-07-26 20:30 +0200
              Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop Thomas Garnier <thgarnie@google.com> - 2017-07-26 20:30 +0200

csiph-web