Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1696395

Re: [PATCH v2 15/23] percpu: introduce bitmap metadata blocks

Show all headers | View raw

On Mon, Jul 24, 2017 at 07:02:12PM -0400, Dennis Zhou wrote:
> From: "Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
> 
> This patch introduces the bitmap metadata blocks and adds the skeleton
> of the code that will be used to maintain these blocks.  Each chunk's
> bitmap is made up of full metadata blocks. These blocks maintain basic
> metadata to help prevent scanning unnecssarily to update hints. Full
> scanning methods are used for the skeleton and will be replaced in the
> coming patches. A number of helper functions are added as well to do
> conversion of pages to blocks and manage offsets. Comments will be
> updated as the final version of each function is added.
> 
> There exists a relationship between PAGE_SIZE, PCPU_BITMAP_BLOCK_SIZE,
> the region size, and unit_size. Every chunk's region (including offsets)
> is page aligned at the beginning to preserve alignment. The end is
> aligned to LCM(PAGE_SIZE, PCPU_BITMAP_BLOCK_SIZE) to ensure that the end
> can fit with the populated page map which is by page and every metadata
> block is fully accounted for. The unit_size is already page aligned, but
> must also be aligned with PCPU_BITMAP_BLOCK_SIZE to ensure full metadata
> blocks.
> 
> Signed-off-by: Dennis Zhou <dennisszhou@gmail.com>

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 15/23] percpu: introduce bitmap metadata blocks Dennis Zhou <dennisz@fb.com> - 2017-07-25 01:10 +0200
  Re: [PATCH v2 15/23] percpu: introduce bitmap metadata blocks Josef Bacik <josef@toxicpanda.com> - 2017-07-25 22:50 +0200

csiph-web