Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1696373

Re: [PATCH v4 2/2] of: Add unit tests for applying overlays

Show all headers | View raw

On Tue, Apr 25, 2017 at 7:09 PM,  <frowand.list@gmail.com> wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Existing overlay unit tests examine individual pieces of the overlay
> code.  The new tests target the entire process of applying an overlay.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---

[...]

> @@ -1261,6 +1263,8 @@ void __init unflatten_device_tree(void)
>
>         /* Get pointer to "/chosen" and "/aliases" nodes for use everywhere */
>         of_alias_scan(early_init_dt_alloc_memory_arch);
> +
> +       unittest_unflatten_overlay_base();

This breaks on systems that don't boot with FDT and call
unflatten_device_tree, namely x86 and UML (UML needs a few hacks to
work) which was a feature of the unittest. Considering applying
overlays on x86 is something we'll want to support, the unittest
should support that case.

Rob

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/2] of: Add unit tests for applying overlays Rob Herring <robh+dt@kernel.org> - 2017-07-25 22:40 +0200
  Re: [PATCH v4 2/2] of: Add unit tests for applying overlays Frank Rowand <frowand.list@gmail.com> - 2017-07-28 01:50 +0200

csiph-web