Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1695976
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable. |
| Date | 2017-07-25 19:50 +0200 |
| Message-ID | <u7c84-5Ol-31@gated-at.bofh.it> (permalink) |
| References | <u756y-1vz-5@gated-at.bofh.it> <u756y-1vz-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jul 25, 2017 at 03:44:28PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > sound/soc/samsung/s3c2412-i2s.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c > index 0a47182..bcd1cbd 100644 > --- a/sound/soc/samsung/s3c2412-i2s.c > +++ b/sound/soc/samsung/s3c2412-i2s.c > @@ -71,7 +71,9 @@ static int s3c2412_i2s_probe(struct snd_soc_dai *dai) > /* Set MPLL as the source for IIS CLK */ > > clk_set_parent(s3c2412_i2s.iis_cclk, clk_get(NULL, "mpll")); > - clk_prepare_enable(s3c2412_i2s.iis_cclk); > + ret = clk_prepare_enable(s3c2412_i2s.iis_cclk); > + if (ret) You miss here path for error handling for things done in s3c_i2sv2_probe(). Best regards, Krzysztof > + return ret; > > s3c2412_i2s.iis_cclk = s3c2412_i2s.iis_pclk; > > -- > 1.9.1 >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-25 12:20 +0200
Re: [PATCH 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable. Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-25 19:50 +0200
Applied "ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown <broonie@kernel.org> - 2017-07-26 16:20 +0200
Re: Applied "ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable." to the asoc tree Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-26 17:50 +0200
Re: Applied "ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown <broonie@kernel.org> - 2017-07-26 18:10 +0200
Re: Applied "ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable." to the asoc tree Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-26 18:20 +0200
csiph-web