Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1695903

Re: [PATCH] objtool: make orc_types.h headers match

From Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] objtool: make orc_types.h headers match
Date 2017-07-25 18:00 +0200
Message-ID <u7apA-4Hw-39@gated-at.bofh.it> (permalink)
References <u79Wy-4x9-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jul 25, 2017 at 05:28:48PM +0200, Arnd Bergmann wrote:
> Building objtool causes a warning on the latest linux-next kernels:
> 
> warning: objtool: orc_types.h differs from kernel
> 
> From what I can tell, we have two slightly different copies of the same
> header, and we try to ensure they are the same with the warning.

Oops!

> This picks the copy from the x86 headers (without the __packed
> annotation), by roll of dice.

You lost ;-)  It should be __packed.

BTW this will also be fixed when the ORC unwinder gets merged, which
will presumably be soon.

> Fixes: 39358a033b2e ("objtool, x86: Add facility for asm code to provide unwind hints")

^^^ This is the one that introduced the bug.

-- 
Josh

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] objtool: make orc_types.h headers match Arnd Bergmann <arnd@arndb.de> - 2017-07-25 17:30 +0200
  Re: [PATCH] objtool: make orc_types.h headers match Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-25 18:00 +0200

csiph-web