Re: [PATCH] livepatch: add (un)patch hooks

From	Joe Lawrence <joe.lawrence@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] livepatch: add (un)patch hooks
Date	2017-07-27 22:50 +0200
Message-ID	<u7XTl-2wS-13@gated-at.bofh.it> (permalink)
References	<u2qEF-Q6-5@gated-at.bofh.it> <u2qEF-Q6-19@gated-at.bofh.it> <u4gBc-6Zb-21@gated-at.bofh.it> <u54eB-5rr-15@gated-at.bofh.it> <u5b6p-1Y8-1@gated-at.bofh.it>
Organization	Red Hat

Show all headers | View raw

On 07/20/2017 12:17 AM, Josh Poimboeuf wrote:
> - The pre-patch and pre-unpatch hooks can be run before the
>   patching/unpatching process begins.

Hi Josh,

By "(un)patching process" are you referring to the klp_patch at large or
each klp_object?  ie, would all klp_objects execute their hooks before
anything is (un)patched?  Just trying to clarify.

> - The post-patch and post-unpatch hooks will need to be run from either
>   klp_complete_transition() or klp_module_coming/going(), depending on
>   whether the to-be-patched module is already loaded or is being
>   loaded/unloaded.

You're suggesting that post-(un)patch-hooks:

  1 - Notify klp_objects when a KLP_(UN)PATCHED transition completes

and for subsequently loaded klp_objects (ie modules):

  2 - On load - notify it with current KLP_(UN)PATCHED state,
      Steady state - same as (1) above.

Thanks,

-- Joe

Thread

Re: [PATCH] livepatch: add (un)patch hooks Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-19 23:00 +0200
  Re: [PATCH] livepatch: add (un)patch hooks Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-20 06:20 +0200
    Re: [PATCH] livepatch: add (un)patch hooks Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-20 06:30 +0200
    Re: [PATCH] livepatch: add (un)patch hooks Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-20 06:40 +0200
    Re: [PATCH] livepatch: add (un)patch hooks Petr Mladek <pmladek@suse.com> - 2017-07-20 18:00 +0200
      Re: [PATCH] livepatch: add (un)patch hooks Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-20 19:10 +0200
    Re: [PATCH] livepatch: add (un)patch hooks Joe Lawrence <joe.lawrence@redhat.com> - 2017-07-27 22:50 +0200
      Re: [PATCH] livepatch: add (un)patch hooks Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-27 23:40 +0200
        Re: [PATCH] livepatch: add (un)patch hooks Joe Lawrence <joe.lawrence@redhat.com> - 2017-07-28 20:10 +0200
          Re: [PATCH] livepatch: add (un)patch hooks Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-28 20:30 +0200

csiph-web