Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1698127

Re: [PATCH] staging: ccree: Fix unnecessary NULL check before kfree'ing it

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Gilad Ben-Yossef <gilad@benyossef.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: ccree: Fix unnecessary NULL check before kfree'ing it
Date Thu, 27 Jul 2017 18:10:02 +0200
Message-ID <u7Twm-8ht-3@gated-at.bofh.it> (permalink)
References <u5jQp-87F-23@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QAcKwDGNLe+Gfm+fsdxO6e441HR6LMwCrHPXp0JIkS4=; b=wSXYiDrBSjIauzp8SMUZnoMWtb/r4BLlW/wYh4Me7d+H2ws+KdGJ7x+iZPEaVLXiuP 7iSy5oJcTEU9yTNbew/q3EVE2OWME3fMAYqV4xZh3B8kdzDfRPvbgHd0Ab0CjXmGnSUC PVMKz9Rf1GVwxuiQ+KSyPZmxnlehhBbNixUbHz1Xrb03qGwSDpbh7BeSs+S3tDHKzlMv hJsGIaUks0TedFxgCGlukXNcZP8jnVGwpgBFM97yRg/jVx0O2SgUE8x4+52sNa7JsTap Go5vwC7tPlDoDFIyiRzDNORIejrsV1uO1jGIbboj6oPHn9CHkmoPd8C7w8O1httvf+Fe k+yA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QAcKwDGNLe+Gfm+fsdxO6e441HR6LMwCrHPXp0JIkS4=; b=Q0qKSdzr6uWQdNdAs6ntbwJ0MAu78w03lnP4b6VzHxr1+Ly4YH8wyEXKFyiYdcrnEW xXsoWr53uLdt1NZDNbimwtYUdntSpS8R91H6Awd3II3KrrM/MFHxJJyWoVyZYxGfwSdH KHX1iB5kbVF7+f7u1b2X4RalA8TRUtRMSvXio8/qfzecsr+iBAc8CUuyBQ6UGnClijmG GSEuwo6lNPToPpk2tv1SBlAyYQdyXWDMdJmjaklQvBhrmr2kRliNPxGTO9HsxkQ1MXqH qzk/btKJFkxVQ4xmb37gIR/yYN66hIuq7DmWHL3RojE8GpXSHHPtsIgu0kRn2WMk9wqC Wvjw==
X-Gm-Message-State AIVw110fY6pR8ivy5QHcRaeyEbXLZN2NTYDp7iZak9fxsK4FL51crcyu Zbhk5qlRbAcbwV8KWHnQfRDPDlr64mYT
X-Received by 10.36.40.84 with SMTP id h81mr5817622ith.12.1501171784697; Thu, 27 Jul 2017 09:09:44 -0700 (PDT)
MIME-Version 1.0
X-Originating-IP [82.81.71.2]
Content-Type text/plain; charset="UTF-8"
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 19
Organization linux.* mail to news gateway
X-Original-Cc Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, Linux kernel mailing list <linux-kernel@vger.kernel.org>
X-Original-Date Thu, 27 Jul 2017 19:09:44 +0300
X-Original-Message-ID <CAOtvUMeHKGaihasV4e4xmQ6MZgs3KtwkY7jqMkQRYwMP5shwjQ@mail.gmail.com>
X-Original-References <1500557827-29853-1-git-send-email-sunil.m@techveda.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1698127

Show key headers only | View raw


Hi,

On Thu, Jul 20, 2017 at 4:37 PM,  <sunil.m@techveda.org> wrote:
> From: Suniel Mahesh <sunil.m@techveda.org>
>
> kfree(NULL) is safe and their is no need for a NULL check. Pointed out
> by checkpatch.
>
> Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
> ---
> Note:
> - Patch was compile tested and built(ARCH=arm) on next-20170719.
>   No build issues reported.

Patch applies against staging-next + latest changes and it builds and runs.

Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>

Gilad

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] staging: ccree: Fix unnecessary NULL check before kfree'ing it sunil.m@techveda.org - 2017-07-20 15:40 +0200
  Re: [PATCH] staging: ccree: Fix unnecessary NULL check before  kfree'ing it Gilad Ben-Yossef <gilad@benyossef.com> - 2017-07-27 18:10 +0200

csiph-web