xattr hash error in 4.13-rc with overlayfs over ext4

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Miklos Szeredi <miklos@szeredi.hu>
Newsgroups	linux.kernel
Subject	xattr hash error in 4.13-rc with overlayfs over ext4
Date	Thu, 27 Jul 2017 14:40:01 +0200
Message-ID	<u7Qf7-65e-1@gated-at.bofh.it> (permalink)
X-Original-To	Tahsin Erdogan <tahsin@google.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=BuulVwIKlt88jzQtxQb/T0udarHYUHzoj8ZtweT6KaI=; b=LwfC/xDTirn8aTy6y6vVhziBbPwpCWPj8SRKcP7q0QOJFRPvvL7WXJOne64hViakrN WVQoKjeucPj5WmkVdw4HN9lW17jLD/z1wkdxjZEd+rl8q/p1skEyvJpq9ghjiCz7cHqu +dL840bHIHyKAyf3WbwuG8RfdsEALWceXRP18=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=BuulVwIKlt88jzQtxQb/T0udarHYUHzoj8ZtweT6KaI=; b=cq3yPUcKWfnZHw7tHLcBxmyq3juGBonpWxtgPBljliyuURDfCp+w6N6dKSgM0VFtdQ A38bZWsqlkxZkFYjRYC4g4+xMnJioVK6hG9FCt1QDgPFH4RESdrrQcTZj74GCyJo5IaJ tVU//xGyN4yLcBNlQgujn5w8fvrlRANY0ZtQq4unk9hnAlFxP0BrbaSvDijyrgXYT8g8 NPBSkfmia+qaZs5McY3c5uM5yZSqAgERY/CZdOxML5BTMs9zS3glpFjsgGF/lM+9hT82 FgGt/TUYsDnmDJ8eHB+Y1ylLSTm0TcfRHSNAMpnRBDqZ19TPxvjYNquqd+MF1MRg5PPx uA9Q==
X-Gm-Message-State	AIVw113kMsylkyKcWBu/Go8YG3m/l3atCANbEyLKX9b4F/DfYomp/y6q GYMzivKDXem1A1rfMcwF30qTyzB5y/Dr
X-Received	by 10.202.76.8 with SMTP id z8mr3797442oia.69.1501159056396; Thu, 27 Jul 2017 05:37:36 -0700 (PDT)
MIME-Version	1.0
X-Originating-IP	[176.63.54.97]
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	"Theodore Ts'o" <tytso@mit.edu>, "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
X-Original-Date	Thu, 27 Jul 2017 14:37:35 +0200
X-Original-Message-ID	<CAJfpegvQhuMnt=2TtfYSiMV=DTLLLbOfrvcR2xQrmvyPU9wSNg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1697941

Show key headers only | View raw

I get the following error on fsck:

Pass 1: Checking inodes, blocks, and sizes
Extended attribute in inode 3093 has a hash (2257320705) which is invalid
Clear<y>? yes
Inode 3093, i_blocks is 16, should be 8.  Fix<y>? yes

To reproduce:

[mount ext4 image]
mkdir xattrhashtest
cd xattrhashtest/
mkdir upper lower work mnt
cd lower/
echo foo > bar
ln bar baz
mount -t overlay overlay -olowerdir=lower,upperdir=upper,workdir=work mnt
cd mnt/
echo xxx >> bar
[umount and fsck]

Reverting commit daf8328172df ("ext4: eliminate xattr entry e_hash
recalculation for removes") fixes it.

Might be an ext4 or overlayfs bug.  Let me know what you think.

Thanks,
Miklos

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

xattr hash error in 4.13-rc with overlayfs over ext4 Miklos Szeredi <miklos@szeredi.hu> - 2017-07-27 14:40 +0200
  Re: xattr hash error in 4.13-rc with overlayfs over ext4 Tahsin Erdogan <tahsin@google.com> - 2017-07-27 20:30 +0200
    Re: xattr hash error in 4.13-rc with overlayfs over ext4 Miklos Szeredi <miklos@szeredi.hu> - 2017-07-27 21:30 +0200
      Re: xattr hash error in 4.13-rc with overlayfs over ext4 Miklos Szeredi <miklos@szeredi.hu> - 2017-07-27 21:40 +0200
        Re: xattr hash error in 4.13-rc with overlayfs over ext4 Tahsin Erdogan <tahsin@google.com> - 2017-07-27 23:00 +0200

csiph-web