Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697931

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Show all headers | View raw

Hi Yong,

I managed to get the Frame Done interrupt with the previous version of this 
driver on the A33 OLinuXino. No data yet (all zeros). I'm still working on it.

One comment below.

On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote:
> Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface
> and CSI1 is used for parallel interface. This is not documented in
> datasheet but by testing and guess.
> 
> This patch implement a v4l2 framework driver for it.
> 
> Currently, the driver only support the parallel interface. MIPI-CSI2,
> ISP's support are not included in this patch.
> 
> Signed-off-by: Yong Deng <yong.deng@magewell.com>
> ---

[...]

> +static int update_buf_addr(struct sun6i_csi *csi, dma_addr_t addr)
> +{
> +	struct sun6i_csi_dev *sdev = sun6i_csi_to_dev(csi);
> +	/* transform physical address to bus address */
> +	dma_addr_t bus_addr = addr - 0x40000000;

What is the source of this magic number? Is it platform dependent? Are there 
other devices doing DMA that need this adjustment?

baruch

> +
> +	regmap_write(sdev->regmap, CSI_CH_F0_BUFA_REG,
> +		     (bus_addr + sdev->planar_offset[0]) >> 2);
> +	if (sdev->planar_offset[1] != -1)
> +		regmap_write(sdev->regmap, CSI_CH_F1_BUFA_REG,
> +			     (bus_addr + sdev->planar_offset[1]) >> 2);
> +	if (sdev->planar_offset[2] != -1)
> +		regmap_write(sdev->regmap, CSI_CH_F2_BUFA_REG,
> +			     (bus_addr + sdev->planar_offset[2]) >> 2);
> +
> +	return 0;
> +}

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Initial Allwinner V3s CSI Support Yong Deng <yong.deng@magewell.com> - 2017-07-27 07:10 +0200
  [PATCH v2 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Yong Deng <yong.deng@magewell.com> - 2017-07-27 07:10 +0200
    Re: [PATCH v2 2/3] dt-bindings: media: Add Allwinner V3s Camera  Sensor Interface (CSI) Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-28 18:40 +0200
      Re: [PATCH v2 2/3] dt-bindings: media: Add Allwinner V3s Camera  Sensor Interface (CSI) Yong <yong.deng@magewell.com> - 2017-07-31 03:00 +0200
  [PATCH v2 3/3] media: MAINTAINERS: add entries for Allwinner V3s CSI Yong Deng <yong.deng@magewell.com> - 2017-07-27 07:10 +0200
  Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI. Baruch Siach <baruch@tkos.co.il> - 2017-07-27 14:20 +0200
    Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI. Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-27 14:30 +0200
      Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI. Yong <yong.deng@magewell.com> - 2017-07-31 02:50 +0200
  Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI. Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-28 18:40 +0200
    Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI. Baruch Siach <baruch@tkos.co.il> - 2017-07-30 08:10 +0200
      Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI. Yong <yong.deng@magewell.com> - 2017-07-31 03:50 +0200
        Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI. Baruch Siach <baruch@tkos.co.il> - 2017-07-31 07:20 +0200
    Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI. Yong <yong.deng@magewell.com> - 2017-07-31 05:20 +0200

csiph-web