Re: [PATCH RESEND] ARM: davinci: don't mark vpif_input structures as 'const'

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] ARM: davinci: don't mark vpif_input structures as 'const'
Date	2017-07-27 13:20 +0200
Message-ID	<u7OZI-5qs-41@gated-at.bofh.it> (permalink)
References	<u7O3E-4Qj-9@gated-at.bofh.it> <u7OGm-556-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 27, 2017 at 12:54 PM, Sekhar Nori <nsekhar@ti.com> wrote:
> Hi Arnd,
>
> On Thursday 27 July 2017 03:42 PM, Arnd Bergmann wrote:
>> A change to the platform data definitions caused a warning in the board code:
>>
>> arch/arm/mach-davinci/board-dm646x-evm.c:680:13: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>> arch/arm/mach-davinci/board-dm646x-evm.c:690:13: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>
> You can replace these by:
>
> arch/arm/mach-davinci/board-da850-evm.c:1221:13: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> arch/arm/mach-davinci/board-da850-evm.c:1231:13: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>
> to match with this patch.

Ok, I thought I had fixed that, but for some reason ended up with the
previous version
of the change text.

>>
>> This is a bit unfortunate, since we generally like structure definitions to
>> be const, but as this is legacy code, the easiest way out is still to
>> remove the 'const' annotation here.
>>
>> Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available")
>> Fixes: 231ce279e6e3 ("ARM: davinci: fix const warnings")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Sekhar Nori <nsekhar@ti.com>

Thanks, applying it now.

        Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] ARM: davinci: don't mark vpif_input structures as 'const' Arnd Bergmann <arnd@arndb.de> - 2017-07-27 12:20 +0200
  Re: [PATCH RESEND] ARM: davinci: don't mark vpif_input structures as  'const' Sekhar Nori <nsekhar@ti.com> - 2017-07-27 13:00 +0200
    Re: [PATCH RESEND] ARM: davinci: don't mark vpif_input structures as 'const' Arnd Bergmann <arnd@arndb.de> - 2017-07-27 13:20 +0200

csiph-web