Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1697809

Re: [PATCH] scsi: sg: only check for dxfer_len greater than 256M

From Hannes Reinecke <hare@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH] scsi: sg: only check for dxfer_len greater than 256M
Date 2017-07-27 10:50 +0200
Message-ID <u7MEy-3Re-23@gated-at.bofh.it> (permalink)
References <u7Lfs-37f-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 07/27/2017 09:11 AM, Johannes Thumshirn wrote:
> Don't make any assumptions on the sg_io_hdr_t::dxfer_direction or the
> sg_io_hdr_t::dxferp in order to determine if it is a valid request. The
> only way we can check for bad requests is by checking if the length exceeds
> 256M.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Fixes: 28676d869bbb (scsi: sg: check for valid direction before starting the
> request)
> Reported-by: Jason L Tibbitts III <tibbs@math.uh.edu>
> Tested-by: Jason L Tibbitts III <tibbs@math.uh.edu>
> Suggested-by: Doug Gilbert <dgilbert@interlog.com>
> Cc: Doug Gilbert <dgilbert@interlog.com>
> Cc: <stable@vger.kernel.org>
> ---
>  drivers/scsi/sg.c | 31 +------------------------------
>  1 file changed, 1 insertion(+), 30 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] scsi: sg: only check for dxfer_len greater than 256M Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-27 09:20 +0200
  Re: [PATCH] scsi: sg: only check for dxfer_len greater than 256M Hannes Reinecke <hare@suse.de> - 2017-07-27 10:50 +0200
  Re: [PATCH] scsi: sg: only check for dxfer_len greater than 256M "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-07-27 15:00 +0200
    Re: [PATCH] scsi: sg: only check for dxfer_len greater than 256M Jason L Tibbitts III <tibbs@math.uh.edu> - 2017-07-27 15:10 +0200

csiph-web