Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697750

Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible

Show key headers only | View raw

Hi Heiko,
Thank you for the quick reply. I will remove the gerrit Change-Ids in my 
v2 patches.

Thanks again,
Rocky

在 2017/7/27 14:36, Heiko Stübner 写道:
> Hi Rocky,
> 
> Am Dienstag, 25. Juli 2017, 17:09:44 CEST schrieb Rocky Hao:
>> attempt to new compatible for thermal founding on RK3328 SoC.
>>
>> Change-Id: Ie6f6d7b4e545891a0035851a923c0412f584140c
>> Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>
> 
> generally looks good but you should not have gerrit Change-Ids in patches
> for mainline. This is true for all patches in this series.
> 
> 
> Heiko
> 
>> ---
>>   Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index
>> 43003aec94bd..e3a6234fb1ac 100644
>> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> @@ -4,6 +4,7 @@ Required properties:
>>   - compatible : should be "rockchip,<name>-tsadc"
>>      "rockchip,rk3228-tsadc": found on RK3228 SoCs
>>      "rockchip,rk3288-tsadc": found on RK3288 SoCs
>> +   "rockchip,rk3328-tsadc": found on RK3328 SoCs
>>      "rockchip,rk3368-tsadc": found on RK3368 SoCs
>>      "rockchip,rk3399-tsadc": found on RK3399 SoCs
>>   - reg : physical base address of the controller and length of memory mapped
> 
> 
> 
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts Rocky Hao <rocky.hao@rock-chips.com> - 2017-07-25 11:10 +0200
  [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible Rocky Hao <rocky.hao@rock-chips.com> - 2017-07-25 11:10 +0200
    Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible Heiko Stübner <heiko@sntech.de> - 2017-07-27 08:40 +0200
      Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC  compatible "rocky.hao" <rocky.hao@rock-chips.com> - 2017-07-27 08:50 +0200
  [PATCH 3/5] arm64: dts: rockchip: add tsadc node for rk3328 SoC Rocky Hao <rocky.hao@rock-chips.com> - 2017-07-25 11:10 +0200
  [PATCH 5/5] arm64: dts: rockchip: Enable tsadc module on RK3328 eavluation board Rocky Hao <rocky.hao@rock-chips.com> - 2017-07-25 11:20 +0200

csiph-web