Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697685

Re: [PATCH] turbostat: Running on virtual machine is not supported

Show all headers | View raw

Henrique,

I like your suggestion, thanks!

BTW. let's discuss (and patch) turbostat on linux-pm, rather than on lkml.

thanks,
-Len


On Tue, Jul 25, 2017 at 11:59 AM, Henrique de Moraes Holschuh
<hmh@hmh.eng.br> wrote:
> On Tue, 25 Jul 2017, Prarit Bhargava wrote:
>> A common way of determining if the system is a virtual machine is to
>> search /proc/cpuinfo flags entry for "hypervisor".  turbostat must output
>> a proper error message when found.
>
> Maybe you could output that message only if it fails to both use
> /dev/msr and perf *and* it is under a virtual machine?  That would have
> better forward compatibility, maybe someday /dev/msr or perf will work
> inside a VM for what turbostat needs...
>
> --
>   Henrique Holschuh



-- 
Len Brown, Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] turbostat: Running on virtual machine is not supported Prarit Bhargava <prarit@redhat.com> - 2017-07-25 15:00 +0200
  Re: [PATCH] turbostat: Running on virtual machine is not supported Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-07-25 18:00 +0200
    Re: [PATCH] turbostat: Running on virtual machine is not supported Len Brown <lenb@kernel.org> - 2017-07-27 05:10 +0200
      Re: [PATCH] turbostat: Running on virtual machine is not supported Prarit Bhargava <prarit@redhat.com> - 2017-07-27 13:50 +0200
      Re: [PATCH] turbostat: Running on virtual machine is not supported Prarit Bhargava <prarit@redhat.com> - 2017-07-28 14:00 +0200

csiph-web