Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1697602
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats |
| Date | 2017-07-27 00:40 +0200 |
| Message-ID | <u7D8d-6ht-11@gated-at.bofh.it> (permalink) |
| References | <u4TsR-6zb-5@gated-at.bofh.it> <u4TsS-6zb-39@gated-at.bofh.it> <u4UoY-7eW-67@gated-at.bofh.it> <u4WqJ-7Z-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jul 19, 2017 at 03:36:28PM +0300, Aviad Krawczyk wrote: > Hi Joe, > > I tried to be consistent with the comments before, that requested > that we will use dev_err exclude some special cases for use netif. > > We will replace the dev_err(&netdev->dev,.. to netdev_err in the > next fix. netdev_err() should be used when possible. You just have to be careful in the probe() function, before netdev exists and you get "(NULL net_device):" or before it is registered and you get "(unnamed net_device)" instead of "eth42" etc. Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-07-19 11:30 +0200
Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats Joe Perches <joe@perches.com> - 2017-07-19 12:30 +0200
Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-07-19 14:40 +0200
Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats Andrew Lunn <andrew@lunn.ch> - 2017-07-27 00:40 +0200
Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-07-30 12:00 +0200
csiph-web