Re: [alsa-devel] [PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog: add MBHC support

From	Damien Riegel <damien.riegel@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog: add MBHC support
Date	2017-07-26 21:40 +0200
Message-ID	<u7Ak2-4uD-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

[Sorry for breaking the thread, but I don't have the initial message to
reply to.]

I tried your patchset and faced some issues regarding removal detection:
the driver detects headphone and microphone removal as soon as I press a
button on the headset.

evtest logs:

	[Headset insertion]
Event: time 10207.841157, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 1
Event: time 10207.841157, -------------- SYN_REPORT ------------
Event: time 10208.039105, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 0
Event: time 10208.039105, -------------- SYN_REPORT ------------
Event: time 10208.075519, type 5 (EV_SW), code 2 (SW_HEADPHONE_INSERT), value 1
Event: time 10208.075519, type 5 (EV_SW), code 4 (SW_MICROPHONE_INSERT), value 1
Event: time 10208.075519, -------------- SYN_REPORT ------------
	[Pressing Volume up Button]
Event: time 10210.590403, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 1
Event: time 10210.590403, type 5 (EV_SW), code 2 (SW_HEADPHONE_INSERT), value 0
Event: time 10210.590403, type 5 (EV_SW), code 4 (SW_MICROPHONE_INSERT), value 0
Event: time 10210.590403, -------------- SYN_REPORT ------------
Event: time 10210.719560, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 0
Event: time 10210.719560, -------------- SYN_REPORT ------------
	[Unplugging]
Event: time 10221.926156, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 1
Event: time 10221.926156, -------------- SYN_REPORT ------------
Event: time 10222.026466, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 0
Event: time 10222.026466, -------------- SYN_REPORT ------------


Also, the KEY_MEDIA is wrongly reported but I don't see that every time,
I think it depends on how fast I plug in the headset. Anyway, I think
that can easily be filtered out by testing the presence of the
microphone.


Regards,
-- 
Damien

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [alsa-devel] [PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog:  add MBHC support Damien Riegel <damien.riegel@savoirfairelinux.com> - 2017-07-26 21:40 +0200
  Re: [alsa-devel] [PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog: add  MBHC support Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-07-27 12:10 +0200

csiph-web