Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite()

From	"Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite()
Date	2017-07-25 16:40 +0200
Message-ID	<u79aa-3YE-29@gated-at.bofh.it> (permalink)
References	(2 earlier) <u6TRN-2Hk-35@gated-at.bofh.it> <u734M-iG-41@gated-at.bofh.it> <u74tP-126-7@gated-at.bofh.it> <u76YH-2Fx-19@gated-at.bofh.it> <u77Bn-2Vd-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 25, 2017 at 02:50:37PM +0200, Jan Kara wrote:
> On Tue 25-07-17 14:15:22, Christoph Hellwig wrote:
> > On Tue, Jul 25, 2017 at 11:35:08AM +0200, Jan Kara wrote:
> > > On Tue 25-07-17 10:01:58, Christoph Hellwig wrote:
> > > > On Tue, Jul 25, 2017 at 01:14:00AM +0300, Kirill A. Shutemov wrote:
> > > > > I guess it's up to filesystem if it wants to reuse the same spot to write
> > > > > data or not. I think your assumptions works for ext4 and xfs. I wouldn't
> > > > > be that sure for btrfs or other filesystems with CoW support.
> > > > 
> > > > Or XFS with reflinks for that matter.  Which currently can't be
> > > > combined with DAX, but I had a somewhat working version a few month
> > > > ago.
> > > 
> > > But in cases like COW when the block mapping changes, the process
> > > must run unmap_mapping_range() before installing the new PTE so that all
> > > processes mapping this file offset actually refault and see the new
> > > mapping. So this would go through pte_none() case. Am I missing something?
> > 
> > Yes, for DAX COW mappings we'd probably need something like this, unlike
> > the pagecache COW handling for which only the underlying block change,
> > but not the page.
> 
> Right. So again nothing where the WARN_ON should trigger.

Yes. I was confused on how COW is handled.

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite() Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-07-24 19:10 +0200
  Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite() "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-07-25 00:20 +0200
    Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite() Christoph Hellwig <hch@lst.de> - 2017-07-25 10:10 +0200
      Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite() Jan Kara <jack@suse.cz> - 2017-07-25 11:40 +0200
        Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite() Christoph Hellwig <hch@lst.de> - 2017-07-25 14:20 +0200
          Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite() Jan Kara <jack@suse.cz> - 2017-07-25 15:00 +0200
            Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite() "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-07-25 16:40 +0200

csiph-web