Re: [RFC 2/2] wl3501_cs: reduce stack size for KASAN

From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 2/2] wl3501_cs: reduce stack size for KASAN
Date	2017-07-25 15:00 +0200
Message-ID	<u77Bo-2Vd-21@gated-at.bofh.it> (permalink)
References	<u1IaB-6eJ-1@gated-at.bofh.it> <u1IaC-6eJ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> Inlining functions with local variables can lead to excessive stack usage
> with KASAN after a previous patch that modifies the outsb/insb helpers
> on x86.
>
> drivers/net/wireless/wl3501_cs.c: In function 'wl3501_rx_interrupt':
> drivers/net/wireless/wl3501_cs.c:1103:1: error: the frame size of 2232 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]
>
> Marking the two callers of insb/outb 'noinline' prevents the compiler
> from adding up the stack usage for each of the local variables passed
> into those, reducing the maximum stack frame size to 800 bytes with
> KASAN again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Arnd, based on the discussion I'm dropping. Please let me know if I
should take this still.

-- 
Kalle Valo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC 2/2] wl3501_cs: reduce stack size for KASAN Kalle Valo <kvalo@codeaurora.org> - 2017-07-25 15:00 +0200
  Re: [RFC 2/2] wl3501_cs: reduce stack size for KASAN Arnd Bergmann <arnd@arndb.de> - 2017-07-25 17:00 +0200

csiph-web