Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695633

Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers

Show all headers | View raw

Hi Stephen,

I forgot to answer one of your questions:

On 22/07/2017 00:20, Stephen Boyd wrote:
> On 07/13, Quentin Schulz wrote:
>> diff --git a/drivers/clk/at91/clk-audio-pll-pad.c b/drivers/clk/at91/clk-audio-pll-pad.c
>> new file mode 100644
>> index 000000000000..10dd6d625696
>> --- /dev/null
>> +++ b/drivers/clk/at91/clk-audio-pll-pad.c
[...]
>> +}
>> +
>> +CLK_OF_DECLARE(of_sama5d2_clk_audio_pll_pad_setup,
>> +	       "atmel,sama5d2-clk-audio-pll-pad",
>> +	       of_sama5d2_clk_audio_pll_pad_setup);
> 
> We can't have a device driver for this?
> 

I tried to work on that but the device does not get probed because the
parent node (pmc) does not register its children. We would need to
modify the DT to add such a support and break DT compat.

As we are speaking about getting rid of clk subnodes (c.f. Rob and
Alexandre answers on the first version of this patch series:
https://patchwork.kernel.org/patch/9805991/) in favor of a clock
controller node that would break the DT compat as well, IMHO it would be
best to break the DT compat as few times as possible and thus, rework
this driver once we switch to a clock controller node.

Thanks,
Quentin
-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers Stephen Boyd <sboyd@codeaurora.org> - 2017-07-22 00:30 +0200
  Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-07-24 10:40 +0200
    Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers Stephen Boyd <sboyd@codeaurora.org> - 2017-07-26 02:30 +0200
  Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-07-25 13:40 +0200
    Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers Stephen Boyd <sboyd@codeaurora.org> - 2017-07-26 02:20 +0200

csiph-web