Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1695625
| From | Johannes Poehlmann <johannes.poehlmann@izt-labs.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v4 4/5] w1: ds1wm: silence interrupts on HW before claiming the interrupt |
| Date | 2017-07-25 13:30 +0200 |
| Message-ID | <u76ci-295-11@gated-at.bofh.it> (permalink) |
| References | <u76ch-295-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
w1: ds1wm: silence interrupts on HW before claiming the interrupt. This way avoid possible invalid interrupts in the initialization phase. Signed-off-by: Johannes Poehlmann <johannes.poehlmann@izt-labs.de> Acked-by: Evgeniy Polyakov <zbr@ioremap.net> --- drivers/w1/masters/ds1wm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c index f8a3ba0..5314379 100644 --- a/drivers/w1/masters/ds1wm.c +++ b/drivers/w1/masters/ds1wm.c @@ -509,6 +509,7 @@ static int ds1wm_probe(struct platform_device *pdev) struct ds1wm_driver_data *plat; struct resource *res; int ret; + u8 inten; if (!pdev) return -ENODEV; @@ -562,6 +563,11 @@ static int ds1wm_probe(struct platform_device *pdev) ds1wm_data->int_en_reg_none = (plat->active_high ? DS1WM_INTEN_IAS : 0); ds1wm_data->reset_recover_delay = plat->reset_recover_delay; + /* Mask interrupts, set IAS before claiming interrupt */ + inten = ds1wm_read_register(ds1wm_data, DS1WM_INT_EN); + ds1wm_write_register(ds1wm_data, + DS1WM_INT_EN, ds1wm_data->int_en_reg_none); + if (res->flags & IORESOURCE_IRQ_HIGHEDGE) irq_set_irq_type(ds1wm_data->irq, IRQ_TYPE_EDGE_RISING); if (res->flags & IORESOURCE_IRQ_LOWEDGE) -- 2.1.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/4] w1: ds1wm: register access patch Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-18 13:30 +0200
[PATCH v3 1/4] w1: ds1wm: fix and simplify register access Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-18 13:30 +0200
Re: [PATCH v3 1/4] w1: ds1wm: fix and simplify register access Greg Kroah-Hartman <greg@kroah.com> - 2017-07-18 16:20 +0200
[PATCH v4 0/5] w1: ds1wm: register access patch Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-25 13:30 +0200
[PATCH v4 1/5] w1: ds1wm: fix register offset (bus shift) calculation Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-25 13:30 +0200
[PATCH v4 5/5] w1: ds1wm: add messages to make incorporation in mfd-drivers easier Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-25 13:30 +0200
[PATCH v4 4/5] w1: ds1wm: silence interrupts on HW before claiming the interrupt Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-25 13:30 +0200
[PATCH v4 2/5] w1: ds1wm: make endian clean and use standard io memory accessors Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-25 13:30 +0200
[PATCH v4 3/5] w1: ds1wm: add level interrupt modes Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-25 13:30 +0200
csiph-web