Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695667

[PATCH 3/3] memory: atmel-ebi: Fix smc cycle xlate converter

Show all headers | View raw

The converter function for translating ns timings in register values was
initialized with a wrong function pointer. This resulted in wrong
register values also for the setup and pulse registers when configuring
the EBI interface trough dts.

Includes a small fix in a comment of the smc driver, which was probably
just a copy'n'paste mistake.

Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
 drivers/memory/atmel-ebi.c | 2 +-
 drivers/mfd/atmel-smc.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index f8a01ae..ebf69ff 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -72,7 +72,7 @@ struct atmel_smc_timing_xlate {
 	{ .name = nm, .converter = atmel_smc_cs_conf_set_pulse, .shift = pos}
 
 #define ATMEL_SMC_CYCLE_XLATE(nm, pos)	\
-	{ .name = nm, .converter = atmel_smc_cs_conf_set_setup, .shift = pos}
+	{ .name = nm, .converter = atmel_smc_cs_conf_set_cycle, .shift = pos}
 
 static void at91sam9_ebi_get_config(struct atmel_ebi_dev *ebid,
 				    struct atmel_ebi_dev_config *conf)
diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c
index 954cf0f..20cc0ea 100644
--- a/drivers/mfd/atmel-smc.c
+++ b/drivers/mfd/atmel-smc.c
@@ -206,7 +206,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_pulse);
  *	     parameter
  *
  * This function encodes the @ncycles value as described in the datasheet
- * (section "SMC Pulse Register"), and then stores the result in the
+ * (section "SMC Cycle Register"), and then stores the result in the
  * @conf->setup field at @shift position.
  *
  * Returns -EINVAL if @shift is invalid, -ERANGE if @ncycles does not fit in
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] memory: atmel-ebi: Fix setting EBI timings through dts Alexander Dahl <ada@thorsis.com> - 2017-07-25 14:10 +0200
  [PATCH 3/3] memory: atmel-ebi: Fix smc cycle xlate converter Alexander Dahl <ada@thorsis.com> - 2017-07-25 14:10 +0200
    Re: [PATCH 3/3] memory: atmel-ebi: Fix smc cycle xlate converter Lee Jones <lee.jones@linaro.org> - 2017-07-26 10:30 +0200
  [PATCH 1/3] memory: atmel-ebi: Fix smc timing return value evaluation Alexander Dahl <ada@thorsis.com> - 2017-07-25 14:10 +0200
  Re: [PATCH 0/3] memory: atmel-ebi: Fix setting EBI timings through  dts Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-07-26 20:30 +0200
  Re: [PATCH 0/3] memory: atmel-ebi: Fix setting EBI timings through  dts Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-07-26 22:40 +0200

csiph-web