Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695587

Re: [PATCH v4 09/12] ASoC: wm9712: add ac97 new bus support

Show all headers | View raw

On Mon, Jul 24, 2017 at 10:49:25PM +0200, Robert Jarzmik wrote:
> Add support for the new ac97 bus model, where devices are automatically
> discovered on AC-Links.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> +	} else {
> +		wm9712->ac97 = snd_soc_new_ac97_codec(codec, WM9712_VENDOR_ID,
> +						      WM9712_VENDOR_ID_MASK);
> +		if (IS_ERR(wm9712->ac97)) {
> +			ret = PTR_ERR(wm9712->ac97);
> +			dev_err(codec->dev,
> +				"Failed to register AC97 codec: %d\n", ret);
> +			return ret;
> +		}
> +
> +		regmap = regmap_init_ac97(wm9712->ac97, &wm9712_regmap_config);
> +		if (IS_ERR(regmap)) {
> +			ret = PTR_ERR(regmap);
> +			goto err_free_ac97_codec;

For the 9713 you had this wrapped in an ifdef? Why did it need an
ifdef there but doesn't for this driver?

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 09/12] ASoC: wm9712: add ac97 new bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-07-24 23:00 +0200
  Re: [PATCH v4 09/12] ASoC: wm9712: add ac97 new bus support Charles Keepax <ckeepax@opensource.cirrus.com> - 2017-07-25 12:30 +0200
    Re: [PATCH v4 09/12] ASoC: wm9712: add ac97 new bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-07-29 00:20 +0200

csiph-web