Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695511

Re: [PATCH v2] mm: Drop useless local parameters of __register_one_node()

Show all headers | View raw

Dou Liyang <douly.fnst@cn.fujitsu.com> writes:

> ... initializes local parameters "p_node" & "parent" for
> register_node().
>
> But, register_node() does not use them.
>
> Remove the related code of "parent" node, cleanup __register_one_node()
> and register_node().
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: isimatu.yasuaki@jp.fujitsu.com
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
> Acked-by: David Rientjes <rientjes@google.com>
> ---
> V1 --> V2:
> Rebase it on 
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
>
>  drivers/base/node.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

That appears to be the last user of parent_node().

Can we start removing it from the topology.h headers for each arch?

cheers

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] mm: Drop useless local parameters of __register_one_node() Michael Ellerman <mpe@ellerman.id.au> - 2017-07-25 11:10 +0200
  Re: [PATCH v2] mm: Drop useless local parameters of  __register_one_node() Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-07-25 13:20 +0200

csiph-web