Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq
Date	2017-07-25 11:00 +0200
Message-ID	<u73R8-Ae-29@gated-at.bofh.it> (permalink)
References	<u6IjE-32F-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Johan Hovold <johan@kernel.org> [170724 02:53]:
> Since commit a8636c89648a ("PM / Runtime: Don't allow to suspend a
> device with an active child"), which went into 4.10, it is no longer
> permitted to set RPM_SUSPENDED state for a device with active children
> (unless power.ignore_children is set).
> 
> This specifically means that the attempts to do just that from the omap
> pm-domain suspend_noirq callback have since been failing whenever a
> child is active, for example:
> 
>   am335x-usb-childs 47400000.usb: runtime PM trying to suspend
>     device but active child
> 
> Silence this warning by dropping the broken pm_runtime_set_suspended()
> call from the omap suspend_noirq callback along with the redundant
> pm_runtime_set_active() in resume_noirq.

With this things still work for me for my PM tests on omap3. Device
suspends and resumes just fine hitting off mode during suspend.

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq Johan Hovold <johan@kernel.org> - 2017-07-24 12:00 +0200
  Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-25 00:20 +0200
    Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Tony Lindgren <tony@atomide.com> - 2017-07-25 09:20 +0200
      Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Tony Lindgren <tony@atomide.com> - 2017-07-25 11:00 +0200
        Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-25 19:50 +0200
    Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Johan Hovold <johan@kernel.org> - 2017-07-25 10:30 +0200
      Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-25 19:50 +0200
        Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Johan Hovold <johan@kernel.org> - 2017-07-26 10:00 +0200
          Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Tony Lindgren <tony@atomide.com> - 2017-07-26 10:20 +0200
            Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Johan Hovold <johan@kernel.org> - 2017-07-26 10:40 +0200
  Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update  from suspend_noirq Tony Lindgren <tony@atomide.com> - 2017-07-25 11:00 +0200

csiph-web