[PATCH] staging: pi433: fix sparse warning: missing static

Path	csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news.etla.org!aioe.org!bofh.it!news.nic.it!robomod
From	David Wittman <dwittman@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: pi433: fix sparse warning: missing static
Date	Mon, 24 Jul 2017 00:50:01 +0200
Message-ID	<u6xRf-4WD-9@gated-at.bofh.it> (permalink)
X-Original-To	gregkh@linuxfoundation.org, linux@Wolf-Entwicklungen.de
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=gym2qQYj2FwxJ/IP7A+fnre2ZLAnGau1JEeMfvcfhbE=; b=AGFgV+rDMiRX1xA1wZ8jAWWAJEsh4YAuarTguhyBwJTIo1aFTVWmiSO/w0vgEcjPve FxRC62RP/EQLu3z4tHfWseEtfgHfuUUVU3jZ+S20jjZV7suIXygxnGB1YPiRdZYhsP8C VjQhfk/D2z2wWRvZ/Nl9dUR5U15QLDCMOd6bS2dQ1E5iKuy11pxhXg/kRCTPINGJnCPW FWbDfy9jiGbl5BwHuo4aEte0UriS2lB1A/dD97AJqQIq9izDsRiUjfvxDdZN63TWnX16 uAr/iAvRKXmEup72oZfN//EWGdT8+p17k1QdpTjicYhA3XqmHu/cmrvsQEQncQ/RKRk0 h8uw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gym2qQYj2FwxJ/IP7A+fnre2ZLAnGau1JEeMfvcfhbE=; b=KB81yW3P13yT5XxUUuLKJVPtTN/NaoNqUVRz5R6xmz3PTzIBFQmEU+ngg/YBevpvZK YKm2tWF/R7r3Nn0hAGL9E/D/m6yeIsfhHOMIE95vDCndMJnI2fNvUtN5jM20PCwLvGcr yeOJ/Dlm9EnPh3ElMYGtbsZZH5Sf5igASmsZzr7ohvkB5q2jpoGPXwxQlK+VYNrsuOvd 2+zOKUpCqzOt1+QvvGosO9L+YTBI3A0E8PCl0VkN8B6OZQs5bLBQxsXzx/Hw6mTMUTi7 jfrkPtXAg5Gh7pZCYS55DdivRgRkwTZ3vFbbx15Nh9FyNj/6eIyjCn2OWwC2ahMhOWuL c+5w==
X-Gm-Message-State	AIVw110P3GlTmxbGFaWiBFqKMRd7jGKUwC9OuQTj1q1IYWWRrdTKDswd e9M0q/aOnw/EUg==
X-Received	by 10.202.82.141 with SMTP id g135mr5537226oib.296.1500850036526; Sun, 23 Jul 2017 15:47:16 -0700 (PDT)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, David Wittman <dwittman@gmail.com>
X-Original-Date	Sun, 23 Jul 2017 17:46:46 -0500
X-Original-Message-ID	<1500850006-5026-1-git-send-email-dwittman@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1694362

Show key headers only | View raw

A few local functions in the pi433 module were getting flagged by Sparse
for missing declarations, so I added static qualifiers to clean up the
warnings.

Signed-off-by: David Wittman <dwittman@gmail.com>
---
 drivers/staging/pi433/pi433_if.c | 4 ++--
 drivers/staging/pi433/rf69.c     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 1bc478a..46461b4 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -313,7 +313,7 @@ struct pi433_instance {
 
 /*-------------------------------------------------------------------------*/
 
-int
+static int
 pi433_receive(void *data)
 {
 	struct pi433_device *dev = data;
@@ -463,7 +463,7 @@ struct pi433_instance {
 		return bytes_total;
 }
 
-int
+static int
 pi433_tx_thread(void *data)
 {
 	struct pi433_device *device = data;
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e391ce7..e5eee84 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -433,7 +433,7 @@ int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum dccPer
 	return rf69_set_dc_cut_off_frequency_intern(spi, REG_AFCBW, dccPercent);
 }
 
-int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent)
+static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent)
 {
 	u8 newValue;
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: pi433: fix sparse warning: missing static David Wittman <dwittman@gmail.com> - 2017-07-24 00:50 +0200
  Re: [PATCH] staging: pi433: fix sparse warning: missing static Marcus Wolf <marcus.wolf@wolf-entwicklungen.de> - 2017-07-24 05:30 +0200

csiph-web