Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694306

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

From Johan Hovold <johan@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.
Date 2017-07-23 15:00 +0200
Message-ID <u6oEh-7Dh-7@gated-at.bofh.it> (permalink)
References <u6kKl-5jb-5@gated-at.bofh.it> <u6kU1-5mz-7@gated-at.bofh.it> <u6o1A-7p5-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sun, Jul 23, 2017 at 03:10:53PM +0300, Dan Carpenter wrote:
> On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote:
> > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote:
> > > Alignment should match with open parenthesis.
> > > This fixes the coding style issue.
> > 
> > No, it need not. This is a choice left up to the author, even if
> > checkpatch happens to complain about it with the --strict option.
> > 
> 
> This is staging code.  Don't try to fight checkpatch.pl in staging...
> You're just making work for everyone else (me) who already just reviewed
> this patch and I don't want to review it a few more times when the next
> person sends the exact same patch.

You can just ignore any greybus patches if you prefer.

I've considered patching checkpatch to drop --strict for at least this
subsystem, but not sure it's worth it.

Johan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: greybus: Match alignment with open parenthesis. Shreeya Patel <shreeya.patel23498@gmail.com> - 2017-07-23 10:50 +0200
  Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. Johan Hovold <johan@kernel.org> - 2017-07-23 11:00 +0200
    Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-23 14:20 +0200
      Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. Johan Hovold <johan@kernel.org> - 2017-07-23 15:00 +0200
        Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-24 09:10 +0200
          Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. Greg KH <gregkh@linuxfoundation.org> - 2017-07-28 06:50 +0200
            Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. Johan Hovold <johan@kernel.org> - 2017-07-28 11:10 +0200
  Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. Greg KH <gregkh@linuxfoundation.org> - 2017-07-28 06:50 +0200

csiph-web