Re: [PATCH V2 net-next 12/21] net-next/hinic: Add qp resources

From	Aviad Krawczyk <aviad.krawczyk@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 net-next 12/21] net-next/hinic: Add qp resources
Date	2017-07-23 12:10 +0200
Message-ID	<u6lZM-6dR-3@gated-at.bofh.it> (permalink)
References	<u4TsR-6zb-5@gated-at.bofh.it> <u4TsR-6zb-3@gated-at.bofh.it> <u56q5-77M-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi David,

Strange that checkpatch.pl --strict didn't warn about it.
We will fix it.

Thanks for review,
Aviad

On 7/20/2017 2:13 AM, David Miller wrote:
> From: Aviad Krawczyk <aviad.krawczyk@huawei.com>
> Date: Wed, 19 Jul 2017 17:19:10 +0800
> 
>> diff --git a/drivers/net/ethernet/huawei/hinic/Makefile b/drivers/net/ethernet/huawei/hinic/Makefile
>> index 519382b..24728f0 100644
>> --- a/drivers/net/ethernet/huawei/hinic/Makefile
>> +++ b/drivers/net/ethernet/huawei/hinic/Makefile
>> @@ -1,5 +1,5 @@
>>  obj-$(CONFIG_HINIC) += hinic.o
>>  
>>  hinic-y := hinic_main.o hinic_tx.o hinic_rx.o hinic_port.o hinic_hw_dev.o \
>> -	   hinic_hw_io.o hinic_hw_wq.o hinic_hw_mgmt.o hinic_hw_api_cmd.o \
>> -	   hinic_hw_eqs.o hinic_hw_if.o
>> \ No newline at end of file
>> +	   hinic_hw_io.o hinic_hw_qp.o hinic_hw_wq.o hinic_hw_mgmt.o \
>> +	   hinic_hw_api_cmd.o hinic_hw_eqs.o hinic_hw_if.o
>> \ No newline at end of file
> 
> Please add the missing newline to the end of this Makefile so that these patches
> don't keep emitting this message.
> 
> .
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 net-next 12/21] net-next/hinic: Add qp resources Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-07-19 11:30 +0200
  Re: [PATCH V2 net-next 12/21] net-next/hinic: Add qp resources David Miller <davem@davemloft.net> - 2017-07-20 01:20 +0200
    Re: [PATCH V2 net-next 12/21] net-next/hinic: Add qp resources Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-07-23 12:10 +0200

csiph-web