Re: [PATCH net-next V2 0/5] Refine virtio-net XDP

Path	csiph.com!goblin1!goblin.stu.neva.ru!feeders.as203319.net!feeder03.as203319.net!aioe.org!bofh.it!news.nic.it!robomod
From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next V2 0/5] Refine virtio-net XDP
Date	Mon, 24 Jul 2017 23:50:03 +0200
Message-ID	<u6ToL-2fn-41@gated-at.bofh.it> (permalink)
References	<u4SZP-68j-5@gated-at.bofh.it> <u6Sj0-1xi-7@gated-at.bofh.it>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mx1.redhat.com 20A776C06
Authentication-Results	ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results	ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com
Dkim-Filter	OpenDKIM Filter v2.11.0 mx1.redhat.com 20A776C06
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-Scanned-By	MIMEDefang 2.79 on 10.5.11.15
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 24 Jul 2017 21:41:06 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 25 Jul 2017 00:41:06 +0300
X-Original-Message-ID	<20170725000830-mutt-send-email-mst@kernel.org>
X-Original-References	<1500454489-16805-1-git-send-email-jasowang@redhat.com> <20170724.133859.192337723544942743.davem@davemloft.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1695148

Show key headers only | View raw

On Mon, Jul 24, 2017 at 01:38:59PM -0700, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Wed, 19 Jul 2017 16:54:44 +0800
> 
> > Hi:
> > 
> > This series brings two optimizations for virtio-net XDP:
> > 
> > - avoid reset during XDP set
> > - turn off offloads on demand
> > 
> > Changes from V1:
> > - Various tweaks on commit logs and comments
> > - Use virtnet_napi_enable() when enabling NAPI on XDP set
> > - Copy the small buffer packet only if xdp_headroom is smaller than
> >   required
> > 
> > Please review.
> 
> Series applied, thanks Jason.
> 
> Michael, I gave you 4+ days to properly review this respin of this
> series.  I felt that was more than sufficient time, even with an
> intervening weekend.  So if you don't like that I applied this without
> your review, please be more punctual in the future.
> 
> Thank you.

My bad - reviewed when I was offline and forgot to send it out.

By luck this is not a big deal:

- Patches 1-4 are good.
- Patch 5 has some problems IMO, but all it does
is try to enable a previously non-working configuration, so
it seems ok to fix it up with follow-up patches as appropriate.

-- 
MST

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next V2 0/5] Refine virtio-net XDP Jason Wang <jasowang@redhat.com> - 2017-07-19 11:00 +0200
  [PATCH net-next V2 2/5] virtio-net: pack headroom into ctx for mergeable buffers Jason Wang <jasowang@redhat.com> - 2017-07-19 11:00 +0200
  Re: [PATCH net-next V2 0/5] Refine virtio-net XDP David Miller <davem@davemloft.net> - 2017-07-24 22:40 +0200
    Re: [PATCH net-next V2 0/5] Refine virtio-net XDP "Michael S. Tsirkin" <mst@redhat.com> - 2017-07-24 23:50 +0200

csiph-web