Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1694954
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] perf, tools: Make build fail on JSON parse error |
| Date | 2017-07-24 19:50 +0200 |
| Message-ID | <u6PEv-87k-29@gated-at.bofh.it> (permalink) |
| References | <u5LMC-ou-23@gated-at.bofh.it> <u5QCB-3jf-3@gated-at.bofh.it> <u6Mng-61e-25@gated-at.bofh.it> <u6PEv-87k-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jul 24, 2017 at 02:42:09PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jul 24, 2017 at 04:16:49PM +0200, Jiri Olsa escreveu: > > On Fri, Jul 21, 2017 at 05:31:59PM -0700, Sukadev Bhattiprolu wrote: > > > Andi Kleen [andi@firstfloor.org] wrote: > > > > From: Andi Kleen <ak@linux.intel.com> > > > > > > > > Today, when a JSON file fails parsing the build continues, > > > > but there are no json files built in, which is difficult to debug later. > > > > Make the build stop on a parse error instead. > > > > > > I see the problem and we were being defensive to not break the build > > > on architectures that don't yet have the PMU event lists. It will be > > > good to check build on an architecture other than x86/powerpc. > > > > > > Also, following comments may no longer be applicable? > > > > Isn't the Andi's change only to fail in case there's > > a real error in process_one_file? I think you can still > > have empty events dir. > > That explains why all the cross builds failed when I added that cset? Hmm, let me test. It was supposed to only fail when there is a file, but it cannot be parsed. -Andi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] perf, tools: Make build fail on JSON parse error Andi Kleen <andi@firstfloor.org> - 2017-07-21 21:30 +0200
Re: [PATCH] perf, tools: Make build fail on JSON parse error Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2017-07-22 02:40 +0200
Re: [PATCH] perf, tools: Make build fail on JSON parse error Jiri Olsa <jolsa@redhat.com> - 2017-07-24 16:20 +0200
Re: [PATCH] perf, tools: Make build fail on JSON parse error Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-24 19:50 +0200
Re: [PATCH] perf, tools: Make build fail on JSON parse error Andi Kleen <andi@firstfloor.org> - 2017-07-24 19:50 +0200
Re: [PATCH] perf, tools: Make build fail on JSON parse error Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2017-07-24 21:10 +0200
csiph-web