Re: [PATCH] KVM: nVMX: consult PFER_MASK and PFER_MATCH before nested vmexit if inject #PF

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KVM: nVMX: consult PFER_MASK and PFER_MATCH before nested vmexit if inject #PF
Date	2017-07-24 16:30 +0200
Message-ID	<u6MwV-655-5@gated-at.bofh.it> (permalink)
References	<u6dzb-Ql-3@gated-at.bofh.it> <u6LKx-5uV-1@gated-at.bofh.it> <u6M3T-5Cy-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 24/07/2017 15:57, Wanpeng Li wrote:
> 
>      if (!((vmcs12->exception_bitmap & (1u << nr)) ||
> -        (nr == PF_VECTOR && vcpu->arch.exception.nested_apf)))
> +        (nr == PF_VECTOR && (vcpu->arch.exception.nested_apf ||
> +            nested_vmx_is_page_fault_vmexit(vmcs12,
> vcpu->arch.exception.error_code)))))
>          return 0;

No, it would be more like

	if (nr == PF_VECTOR
	    ? (vcpu->arch.exception.nested_apf ||
               nested_vmx_is_page_fault_vmexit(vmcs12, vcpu->arch.exception.error_code))
            : (vmcs12->exception_bitmap & (1u << nr)))

but I've sent an RFC patch that also fixes the exit qualification.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: nVMX: consult PFER_MASK and PFER_MATCH before nested vmexit if inject #PF Wanpeng Li <kernellwp@gmail.com> - 2017-07-23 03:10 +0200
  Re: [PATCH] KVM: nVMX: consult PFER_MASK and PFER_MATCH before nested  vmexit if inject #PF Paolo Bonzini <pbonzini@redhat.com> - 2017-07-24 15:40 +0200
    Re: [PATCH] KVM: nVMX: consult PFER_MASK and PFER_MATCH before nested  vmexit if inject #PF Wanpeng Li <kernellwp@gmail.com> - 2017-07-24 16:00 +0200
      Re: [PATCH] KVM: nVMX: consult PFER_MASK and PFER_MATCH before nested  vmexit if inject #PF Paolo Bonzini <pbonzini@redhat.com> - 2017-07-24 16:30 +0200

csiph-web