Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694653

Re: [PATCH] cpufreq: intel_pstate: Fix cpuinfo_cur_freq after performance governor changes

Show all headers | View raw

On Monday, July 24, 2017 05:43:14 AM Huaisheng HS1 Ye wrote:
> After commit 82b4e03e01bc (intel_pstate: skip scheduler hook when
> in "performance" mode) Software P-state control modes couldn't get
> dynamic value during performance mode,

Please explain what you mean here.

I guess you carried out some tests and the results were not as expected,
so what was the test?

> and it still in last value from powersave mode, so clear its value to get
> same behavior as Hardware P-state to avoid confusion.

And please explain why it should be fixed the way you've done that.

> Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 6cd5035..c675626 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2050,6 +2050,7 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
>  		 */
>  		intel_pstate_clear_update_util_hook(policy->cpu);
>  		intel_pstate_max_within_limits(cpu);
> +		cpu->sample.core_avg_perf = 0;
>  	} else {
>  		intel_pstate_set_update_util_hook(policy->cpu);
>  	}
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: intel_pstate: Fix cpuinfo_cur_freq after performance  governor changes Huaisheng HS1 Ye <yehs1@lenovo.com> - 2017-07-24 07:50 +0200
  Re: [PATCH] cpufreq: intel_pstate: Fix cpuinfo_cur_freq after performance governor changes "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-24 13:50 +0200
    Re: [PATCH] cpufreq: intel_pstate: Fix cpuinfo_cur_freq after performance governor changes "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 02:10 +0200
      Re: [PATCH] cpufreq: intel_pstate: Fix cpuinfo_cur_freq after  performance governor changes Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-07-25 05:00 +0200
        Re: [PATCH] cpufreq: intel_pstate: Fix cpuinfo_cur_freq after  performance governor changes Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-07-25 16:40 +0200
        Re: [PATCH] cpufreq: intel_pstate: Fix cpuinfo_cur_freq after performance governor changes "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 17:50 +0200
          [PATCH] cpufreq: intel_pstate: Drop ->get from intel_pstate structure "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 01:00 +0200
            Re: [PATCH] cpufreq: intel_pstate: Drop ->get from intel_pstate  structure Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-27 05:50 +0200
        Re: [PATCH] cpufreq: intel_pstate: Fix cpuinfo_cur_freq after performance governor changes "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 00:00 +0200

csiph-web