Re: [PATCH v1 6/6] usb: dwc3: core: Notify USB3 PHY as well for DRD modes

From	Manu Gautam <mgautam@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 6/6] usb: dwc3: core: Notify USB3 PHY as well for DRD modes
Date	2017-07-24 12:10 +0200
Message-ID	<u6Itj-3l5-17@gated-at.bofh.it> (permalink)
References	<u5DYJ-45z-3@gated-at.bofh.it> <u5DYJ-45z-1@gated-at.bofh.it> <u5JKN-7DO-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 7/21/2017 10:39 PM, Stephen Boyd wrote:
> On 07/21/2017 04:02 AM, Manu Gautam wrote:
>> Driver currently notifies only USB3 PHY for mode change.
>> Extend this to USB3 PHY so that driver based on the mode
>> can release system resources - clocks, regulators etc.
>> and can even turn off PHY during runtime suspend.
>>
>> Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
> This patch is confusing because you say "notify for usb3 phy", but then
> combine a change to remove the NULL pointer check on phy_set_mode() for
> the usb2 phy. Please describe everything that's happening in a patch in
> the commit text.

Sure, will add a comment for that.
It was done to align with other phy_ops usage in the driver. Also, these
wrapper functions already have a NULL pointer check.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 6/6] usb: dwc3: core: Notify USB3 PHY as well for DRD modes Manu Gautam <mgautam@codeaurora.org> - 2017-07-21 13:10 +0200
  Re: [PATCH v1 6/6] usb: dwc3: core: Notify USB3 PHY as well for DRD  modes Stephen Boyd <sboyd@codeaurora.org> - 2017-07-21 19:20 +0200
    Re: [PATCH v1 6/6] usb: dwc3: core: Notify USB3 PHY as well for DRD  modes Manu Gautam <mgautam@codeaurora.org> - 2017-07-24 12:10 +0200

csiph-web