Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume

From	Manu Gautam <mgautam@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume
Date	2017-07-24 10:50 +0200
Message-ID	<u6HdV-2qQ-17@gated-at.bofh.it> (permalink)
References	<u5A4N-1mZ-5@gated-at.bofh.it> <u5BNf-2yc-13@gated-at.bofh.it> <u5C6E-2US-57@gated-at.bofh.it> <u5Cgi-2Y7-17@gated-at.bofh.it> <u6Ezn-Jj-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Baolin,


On 7/24/2017 11:26 AM, Baolin Wang wrote:

>>>> Other than what I pushed in my patch -
>>>> ("usb: dwc3: Don't reinitialize core during host bus-suspend/resume")
>>>> Just performing pm_request_resume or handling same in dwc3 glue
>>>> driver should be sufficient.
>>> Yes.
>>>
>>>> Also, what is trigger for runtime_resume for your platform?
>>> In our platform glue layer, we have extcon events to notify there are
>>> devices connected, then gule layer will resume dwc3 device.
>>>
>> IMO you can just perform resume of &dwc->xhci->dev instead of resuming dwc3.
>> Since, dwc3 is parent of xhci that will trigger resume of dwc3 as well.
> I am not sure this is good enough but it seems can solve some
> problems, then we do not need resume/suspend host in dwc3 core.

In that case can we proceed with this patch:
[1] https://www.spinics.net/lists/linux-usb/msg158682.html

For your platform you can pick this patch and resume dwc->xhci->dev resume
from your glue driver.
Do you have any other concerns?

Thread

[PATCH] usb: dwc3: Support the dwc3 host suspend/resume Baolin Wang <baolin.wang@linaro.org> - 2017-07-21 09:00 +0200
  Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume Manu Gautam <mgautam@codeaurora.org> - 2017-07-21 10:50 +0200
    Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume Baolin Wang <baolin.wang@linaro.org> - 2017-07-21 11:10 +0200
      Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume Manu Gautam <mgautam@codeaurora.org> - 2017-07-21 11:20 +0200
        Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume Baolin Wang <baolin.wang@linaro.org> - 2017-07-24 08:00 +0200
          Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume Manu Gautam <mgautam@codeaurora.org> - 2017-07-24 10:50 +0200
            Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume Baolin Wang <baolin.wang@linaro.org> - 2017-07-24 11:20 +0200
              Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume Manu Gautam <mgautam@codeaurora.org> - 2017-07-24 11:40 +0200
                Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume Baolin Wang <baolin.wang@linaro.org> - 2017-07-24 13:50 +0200

csiph-web