Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line
Date	2017-07-24 10:00 +0200
Message-ID	<u6Grw-1RH-19@gated-at.bofh.it> (permalink)
References	<u5TK9-5cO-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 22, 2017 at 03:51:21PM +1200, Derek Robson wrote:
> Fixed checkpatch errors of "please, no spaces at the start of a line"
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  drivers/staging/pi433/rf69.c      |   4 +-
>  drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++-------------------
>  2 files changed, 105 insertions(+), 105 deletions(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index d931437f0b6a..f450bbf3fbbc 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mant
>  	// check value for mantisse and exponent
>  	if (exponent > 7)   INVALID_PARAM;
>  	if ( (mantisse!=mantisse16) &&
> -	     (mantisse!=mantisse20) &&
> -             (mantisse!=mantisse24) ) INVALID_PARAM;
> +		(mantisse!=mantisse20) &&
> +		(mantisse!=mantisse24) ) INVALID_PARAM;
>  

This is wrong.  It should be aligned like this:

	if (exponent > 7)
		INVALID_PARAM;
	if (mantisse != mantisse16 &&
	    mantisse != mantisse20 &&
	    mantisse != mantisse24)
		INVALID_PARAM;

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] staging: pi433: - style fix, space at start of line Derek Robson <robsonde@gmail.com> - 2017-07-22 06:00 +0200
  Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line Marcus Wolf <marcus.wolf@wolf-entwicklungen.de> - 2017-07-22 10:40 +0200
  Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-24 10:00 +0200

csiph-web