Re: [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator framework

From	Lars-Peter Clausen <lars@metafoo.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator framework
Date	2017-07-24 09:40 +0200
Message-ID	<u6G89-1L7-5@gated-at.bofh.it> (permalink)
References	<u4Wh4-8vz-9@gated-at.bofh.it> <u4Wh4-8vz-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/19/2017 02:20 PM, Bartosz Golaszewski wrote:
[...]
> +void irq_sim_fini(struct irq_sim *sim)
> +{

Not very likely to happen in practice, but for correctness we should
probably put a irq_work_sync() here for each of the IRQs to make sure that
the memory associated with the irq_sim_work_ctx struct is no longer accessed
and that handle_simple_irq() is not called after irq_free_descs().

> +	irq_free_descs(sim->irq_base, sim->irq_count);
> +	kfree(sim->irqs);
> +}
> +EXPORT_SYMBOL_GPL(irq_sim_fini);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] irq/irq_sim: add a simple interrupt simulator framework Bartosz Golaszewski <brgl@bgdev.pl> - 2017-07-19 14:30 +0200
  Re: [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator  framework Jonathan Cameron <jic23@kernel.org> - 2017-07-22 23:00 +0200
    Re: [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator framework Bartosz Golaszewski <brgl@bgdev.pl> - 2017-07-24 09:00 +0200
  Re: [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator  framework Lars-Peter Clausen <lars@metafoo.de> - 2017-07-24 09:40 +0200

csiph-web