Re: [Patch v5 06/12] [media] v4l2-ioctl: add HEVC format description

From	Smitha T Murthy <smitha.t@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v5 06/12] [media] v4l2-ioctl: add HEVC format description
Date	2017-07-24 07:00 +0200
Message-ID	<u6DDj-6W-3@gated-at.bofh.it> (permalink)
References	<tTXqa-6Rc-3@gated-at.bofh.it> <tTXqa-6Rc-35@gated-at.bofh.it> <tTXqa-6Rc-33@gated-at.bofh.it> <u5jnl-7Tm-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-07-20 at 15:07 +0200, Hans Verkuil wrote:
> On 19/06/17 07:10, Smitha T Murthy wrote:
> > HEVC is a video coding format
> > 
> > Signed-off-by: Smitha T Murthy <smitha.t@samsung.com>
> > ---
> >  drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> > index e5a2187..4f6f8d9 100644
> > --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> > @@ -1257,6 +1257,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> >  		case V4L2_PIX_FMT_VC1_ANNEX_L:	descr = "VC-1 (SMPTE 412M Annex L)"; break;
> >  		case V4L2_PIX_FMT_VP8:		descr = "VP8"; break;
> >  		case V4L2_PIX_FMT_VP9:		descr = "VP9"; break;
> > +		case V4L2_PIX_FMT_HEVC:		descr = "HEVC"; break;
> 
> Add a little comment at the end of the line: /* aka H.265 */
> 
> After that you can add my:
> 
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> 
> Regards,
> 
> 	Hans
> 
Ok I will make the change. Thanks for the review.

Regards,
Smitha

> >  		case V4L2_PIX_FMT_CPIA1:	descr = "GSPCA CPiA YUV"; break;
> >  		case V4L2_PIX_FMT_WNVA:		descr = "WNVA"; break;
> >  		case V4L2_PIX_FMT_SN9C10X:	descr = "GSPCA SN9C10X"; break;
> > 
> 
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [Patch v5 06/12] [media] v4l2-ioctl: add HEVC format description Hans Verkuil <hverkuil@xs4all.nl> - 2017-07-20 15:10 +0200
  Re: [Patch v5 06/12] [media] v4l2-ioctl: add HEVC format  description Smitha T Murthy <smitha.t@samsung.com> - 2017-07-24 07:00 +0200

csiph-web