Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694400

RE: [PATCH] qe: fix compile issue for arm64

Show all headers | View raw

On Fri, 2017-07-21 at 02:34PM, Michael Ellerman <mpe@ellerman.id.au> wrote:

> -----Original Message-----
> From: Michael Ellerman [mailto:mpe@ellerman.id.au]
> Sent: Friday, July 21, 2017 2:34 PM
> To: Qiang Zhao <qiang.zhao@nxp.com>; oss@buserror.net
> Cc: valentin.longchamp@keymile.com; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org; Qiang Zhao <qiang.zhao@nxp.com>
> Subject: Re: [PATCH] qe: fix compile issue for arm64
> 
> Zhao Qiang <qiang.zhao@nxp.com> writes:
> 
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> >  drivers/soc/fsl/qe/qe.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index
> > 2ef6fc6..d48fa4a 100644
> > --- a/drivers/soc/fsl/qe/qe.c
> > +++ b/drivers/soc/fsl/qe/qe.c
> > @@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate,
> unsigned int multiplier)
> >  	/* Errata QE_General4, which affects some MPC832x and MPC836x
> SOCs, says
> >  	   that the BRG divisor must be even if you're not using divide-by-16
> >  	   mode. */
> > +#ifdef CONFIG_PPC
> >  	if (pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x)
> > +#endif
> >  		if (!div16 && (divisor & 1) && (divisor > 3))
> >  			divisor++;
> 
> Are you sure that's what you want to do on arm64 ?

Is there any problem?

Best Regards
Qiang Zhao

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] qe: fix compile issue for arm64 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-21 08:40 +0200
  RE: [PATCH] qe: fix compile issue for arm64 Qiang Zhao <qiang.zhao@nxp.com> - 2017-07-24 04:10 +0200
    Re: [PATCH] qe: fix compile issue for arm64 Scott Wood <oss@buserror.net> - 2017-07-24 05:40 +0200

csiph-web