Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694397

Re: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies

Show all headers | View raw

On 2017年07月22日 05:12, Arnd Bergmann wrote:
> A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m,
> the rockchip drm driver will fail to link:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x6c): undefined reference to `extcon_get_property'
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_check_sink_connection':
> cdn-dp-core.c:(.text.cdn_dp_check_sink_connection+0x80): undefined reference to `extcon_get_state'
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_enable':
> cdn-dp-core.c:(.text.cdn_dp_enable+0x748): undefined reference to `extcon_get_property'
>
> The problem is that that the sub-drivers are now all linked into the
> main rockchip drm module, which breaks all the Kconfig dependencies
> that are specified in the options for those sub-drivers.
>
> This clarifies the dependency to ensure that we can only turn on the DP
> driver when EXTCON is reachable. As the 'select' statements can now
> cause additional options to become built-in when they should be
> loadable modules, I'm moving those into the main driver config option.
> The dependency on DRM_ROCKCHIP can be reduced into a single 'if'
> statement here for brevity, but this has no functional effect.
>
> Fixes: b6705157b2db ("drm/rockchip: add extcon dependency for DP")
> Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.")
> Link:https://patchwork.kernel.org/patch/9648761/
> Acked-by: Guenter Roeck<groeck@chromium.org>
> Tested-by: Jeffy Chen<jeffy.chen@rock-chips.com>
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>

Pushed to drm-misc-fixes.

Thanks.

-- 
Ｍark Yao

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies Arnd Bergmann <arnd@arndb.de> - 2017-07-21 23:20 +0200
  Re: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies Mark yao <mark.yao@rock-chips.com> - 2017-07-24 04:00 +0200

csiph-web