Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency

From	Steve Longerbeam <slongerbeam@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency
Date	2017-07-22 21:00 +0200
Message-ID	<u67N7-5v5-5@gated-at.bofh.it> (permalink)
References	<u5IYp-788-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Acked-by: Steve Longerbeam <steve_longerbeam@mentor.com>

On 07/21/2017 09:21 AM, Arnd Bergmann wrote:
> Without this, I get a build error:
> 
> drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt':
> drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration]
> 
> Fixes: e130291212df ("[media] media: Add i.MX media core driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/staging/media/imx/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50bcea39..719508fcb0e9 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
>   config VIDEO_IMX_MEDIA
>   	tristate "i.MX5/6 V4L2 media core driver"
>   	depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> +	depends on VIDEO_V4L2_SUBDEV_API
>   	select V4L2_FWNODE
>   	---help---
>   	  Say yes here to enable support for video4linux media controller
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-21 18:30 +0200
  Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency Steve Longerbeam <slongerbeam@gmail.com> - 2017-07-22 21:00 +0200

csiph-web