Re: [PATCH 1/2] RDMA/ocrdma: Fix an error code in ocrdma_alloc_pd()

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] RDMA/ocrdma: Fix an error code in ocrdma_alloc_pd()
Date	2017-07-22 19:30 +0200
Message-ID	<u66o2-4Lp-15@gated-at.bofh.it> (permalink)
References	<u2H2O-2IC-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 7/13/2017 3:46 AM, Dan Carpenter wrote:
> We should preserve the original "status" error code instead of resetting
> it to zero.  Returning ERR_PTR(0) is the same as NULL and results in a
> NULL dereference in the callers.  I added a printk() on error instead.
> 
> Fixes: 45e86b33ec8b ("RDMA/ocrdma: Cache recv DB until QP moved to RTR")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

This was accepted into 4.13-rc, thanks.

-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] RDMA/ocrdma: Fix an error code in ocrdma_alloc_pd() Doug Ledford <dledford@redhat.com> - 2017-07-22 19:30 +0200

csiph-web